Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align credentials stores part 17 #27433

Merged
merged 17 commits into from
Jun 22, 2023
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Packs/Pipl/.pack-ignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[file:Pipl.yml]
ignore=IN144,IN145,DB100,IN154
ignore=IN144,DB100,IN154

[file:Pipl_image.png]
ignore=IM111
5 changes: 4 additions & 1 deletion Packs/Pipl/Integrations/Pipl/Pipl.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ var sendRequest = function(args) {

var queryArgs = {};
var argKeys = Object.keys(args);
var key = params.credentials_api_key !== null ? params.credentials_api_key.password : params.key;
maimorag marked this conversation as resolved.
Show resolved Hide resolved
if (key !== null)
maimorag marked this conversation as resolved.
Show resolved Hide resolved
return('API key must be provided.');
for (var i = 0; i < argKeys.length; i++) {
queryArgs[argKeys[i].replace('-','_')] = args[argKeys[i]];
}
Expand All @@ -21,7 +24,7 @@ var sendRequest = function(args) {
Headers: {
'Content-Type': ['application/x-www-form-urlencoded']
},
Body: 'key=' + params.key
Body: 'key=' + key
},
params.insecure,
params.proxy
Expand Down
8 changes: 7 additions & 1 deletion Packs/Pipl/Integrations/Pipl/Pipl.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,13 @@ configuration:
name: key
defaultvalue: ""
type: 4
required: true
required: false
hidden: true
- displaypassword: API Key
name: credentials_api_key
required: false
hiddenusername: true
type: 9
- display: Trust any certificate (not secure)
name: insecure
type: 8
Expand Down
64 changes: 64 additions & 0 deletions Packs/Pipl/Integrations/Pipl/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@

### pipl-search

***
Search for required query

#### Base Command

`pipl-search`

#### Input

| **Argument Name** | **Description** | **Required** |
| --- | --- | --- |
| email | Email address to search. | Optional |
| phone | Home/work/mobile phone number to search. | Optional |
| username | Username/screen-name to search. Minimum 4 characters. | Optional |
| first-name | First name to search. Minimum 2 characters. | Optional |
| last-name | Last name to search. Minimum 2 characters. | Optional |
| middle-name | Middle name or middle initial to search. | Optional |
| raw-name | Full name to search. Use this parameter if the accurate name parts (first/middle/last) are not available, this parameter will only be used in absence of first-name and last-name. | Optional |
| country | A two-letter country code to searchs. | Optional |
| state | A United States, Canada, Great Britain or Australia state code. If a US state is provided and no country specified, we’ll assume the country to be US. | Optional |
| city | City to search. | Optional |
| zipcode | ZIP code to search. | Optional |
| raw-address | Full address to search. | Optional |
| age | Age to search in String, an exact (YY) or approximate (YY-YY) age. | Optional |
| columns | Order of columns to be displayed in results (comma seperated list of values). | Optional |

#### Context Output

| **Path** | **Type** | **Description** |
| --- | --- | --- |
| Account.Email.Address | unknown | Email addresses |
| Account.IDs | unknown | User IDs |
| Account.Addresses | unknown | Addresses \(geographic\) |
| Account.Names | unknown | Full names |
| Account.Phones | unknown | Phone numbers |
| Account.Usernames | unknown | Online platforms usernames |
### email

***
Searches for information regarding given email address

#### Base Command

`email`

#### Input

| **Argument Name** | **Description** | **Required** |
| --- | --- | --- |
| email | Email address to search for. | Required |

#### Context Output

| **Path** | **Type** | **Description** |
| --- | --- | --- |
| Account.Email.Address | unknown | Email addresses |
| Account.IDs | unknown | User IDs |
| Account.Addresses | unknown | Addresses \(geographic\) |
| Account.Names | unknown | Full names |
| Account.Phones | unknown | Phone numbers |
| Account.Usernames | unknown | Online platforms usernames |
5 changes: 5 additions & 0 deletions Packs/Pipl/ReleaseNotes/1_0_6.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@

#### Integrations

##### Pipl
Added the *API Key* integration parameters to support credentials fetching object.
2 changes: 1 addition & 1 deletion Packs/Pipl/pack_metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "Pipl",
"description": "Get contact, social, and professional information about people",
"support": "xsoar",
"currentVersion": "1.0.5",
"currentVersion": "1.0.6",
"author": "Cortex XSOAR",
"url": "https://www.paloaltonetworks.com/cortex",
"email": "",
Expand Down
2 changes: 1 addition & 1 deletion Packs/Twilio/.pack-ignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[file:Twilio.yml]
ignore=IN145,IN140
ignore=IN140

[file:Twilio_image.png]
ignore=IM111
Expand Down
9 changes: 7 additions & 2 deletions Packs/Twilio/Integrations/Twilio/Twilio.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,17 @@
var sendRequest = function(method, url, body) {
var username = (params.credentials_token!== undefined)? params.credentials_token.identifier : params.sid;
maimorag marked this conversation as resolved.
Show resolved Hide resolved
var password = (params.credentials_token!== undefined)? params.credentials_token.password : params.token;
if (!(username && password)){
throw('API key and Auth token must be provided.');
maimorag marked this conversation as resolved.
Show resolved Hide resolved
}
var res = http(
params.server.replace(/[\/]+$/, '')+'/'+params.sid+'/Messages.json',
{
Method: method,
Body: body,
Headers: {'Content-Type': ['application/x-www-form-urlencoded']},
Username: params.sid,
Password: params.token
Username: username,
Password: password
},
params.insecure,
params.proxy
Expand Down
12 changes: 10 additions & 2 deletions Packs/Twilio/Integrations/Twilio/Twilio.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,20 @@ configuration:
name: sid
defaultvalue: ""
type: 0
required: true
required: false
hidden: true
- display: Auth token
name: token
defaultvalue: ""
type: 4
required: true
required: false
hidden: true
- display: Account SID
name: credentials_token
required: false
type: 9
displaypassword: Auth token
section: Connect
- display: Default sending number (e.g. +123456789101)
name: from
defaultvalue: ""
Expand Down
6 changes: 6 additions & 0 deletions Packs/Twilio/ReleaseNotes/1_0_5.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@

#### Integrations

##### Twilio
Added the *API key* and *Auth token* integration parameters to support credentials fetching object.
maimorag marked this conversation as resolved.
Show resolved Hide resolved

2 changes: 1 addition & 1 deletion Packs/Twilio/pack_metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "Twilio",
"description": "Send SMS notifications",
"support": "xsoar",
"currentVersion": "1.0.4",
"currentVersion": "1.0.5",
"author": "Cortex XSOAR",
"url": "https://www.paloaltonetworks.com/cortex",
"email": "",
Expand Down