Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align credentials stores part 26 #27718

Merged
merged 15 commits into from
Jul 3, 2023
Merged

Conversation

maimorag
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

Relates: link to the issue

Description

Change the type of credentials, from type 4 to type 9.

Minimum version of Cortex XSOAR

  • 6.5.0

Does it break backward compatibility?

  • No

@maimorag maimorag requested a review from Shellyber June 26, 2023 09:36
@maimorag
Copy link
Contributor Author

maimorag commented Jun 27, 2023

CheckPhish-test fails due to reaching the daily limit, I opened a ticket to lab
Jira ticket - in blocked, waiting for PM

@Shellyber
Copy link
Contributor

@maimorag you have more failures in the build, please have a look.

@maimorag
Copy link
Contributor Author

build fails on CJ105 since FireEyeISIGHT Either FireEye iSIGHT does not have any test playbooks and there is no unit tests file.

@maimorag maimorag requested a review from ostolero as a code owner June 29, 2023 10:55
@maimorag maimorag added the ForceMerge Forcing the merge of the PR despite the build status label Jun 29, 2023
Packs/isight/ReleaseNotes/1_0_3.md Outdated Show resolved Hide resolved
Packs/CheckPhish/ReleaseNotes/1_0_18.md Outdated Show resolved Hide resolved
maimorag and others added 2 commits June 29, 2023 16:12
Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>
Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>
@dantavori dantavori merged commit f009c87 into master Jul 3, 2023
@dantavori dantavori deleted the align_credentials_stores_part_26 branch July 3, 2023 08:17
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Jul 26, 2023
* align

* Align credentials stores - part 26

* fix

* fix rl

* added commands to readme

* add description

* checkfish

* commit revert

* commit

* Update Packs/isight/ReleaseNotes/1_0_3.md

Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>

* Update Packs/CheckPhish/ReleaseNotes/1_0_18.md

Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>

---------

Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-approved ForceMerge Forcing the merge of the PR despite the build status
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants