Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align credentials stores part 26 #27718

Merged
merged 15 commits into from
Jul 3, 2023
Merged
2 changes: 1 addition & 1 deletion Packs/CheckPhish/.pack-ignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
[file:CheckPhish.yml]
ignore=IN135,IN145
ignore=IN135
6 changes: 4 additions & 2 deletions Packs/CheckPhish/Integrations/CheckPhish/CheckPhish.py
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,9 @@ def main():
good_disp = argToList(demisto_params.get('good_disp'))
susp_disp = argToList(demisto_params.get('susp_disp'))
bad_disp = argToList(demisto_params.get('bad_disp'))

api_key = demisto_params.get('credentials_api_token', {}).get('password') or demisto_params.get('token')
if not api_key:
raise DemistoException('API token must be provided.')
unite_dispositions(good_disp, susp_disp, bad_disp)

reliability = demisto_params.get('integrationReliability')
Expand All @@ -239,7 +241,7 @@ def main():

params = {
'base_url': demisto_params['url'],
'api_key': demisto_params.get('token'),
'api_key': api_key,
'use_ssl': not demisto_params.get('insecure', False),
'reliability': reliability
}
Expand Down
10 changes: 8 additions & 2 deletions Packs/CheckPhish/Integrations/CheckPhish/CheckPhish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,14 @@ configuration:
type: 0
- display: API Token
name: token
required: true
required: false
type: 4
hidden: true
- displaypassword: API Token
name: credentials_api_token
required: false
hiddenusername: true
type: 9
- display: 'Good Dispositions (CheckPhish labels for non-phishing URLs. Default is "clean")'
name: good_disp
options:
Expand Down Expand Up @@ -206,5 +212,5 @@ script:
script: '-'
type: python
subtype: python3
dockerimage: demisto/python3:3.10.11.54132
dockerimage: demisto/python3:3.10.12.63474
fromversion: 5.0.0
6 changes: 6 additions & 0 deletions Packs/CheckPhish/ReleaseNotes/1_0_18.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@

#### Integrations

##### CheckPhish
- Added the *API Token* integration parameters to support credentials fetching object.
maimorag marked this conversation as resolved.
Show resolved Hide resolved
- Updated the Docker image to: *demisto/python3:3.10.12.63474*.
2 changes: 1 addition & 1 deletion Packs/CheckPhish/pack_metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "CheckPhish",
"description": "Check any URL to detect supsicious behavior.",
"support": "xsoar",
"currentVersion": "1.0.17",
"currentVersion": "1.0.18",
"author": "Cortex XSOAR",
"url": "https://www.paloaltonetworks.com/cortex",
"email": "",
Expand Down
2 changes: 1 addition & 1 deletion Packs/isight/.pack-ignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
[file:FireEyeISIGHT.yml]
ignore=IN144,IN145,IN107
ignore=IN144,IN107
5 changes: 4 additions & 1 deletion Packs/isight/Integrations/FireEyeISIGHT/FireEyeISIGHT.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@

var baseUrl = 'https://api.isightpartners.com'; // iSight base url
var publicKey = params.publicKey;
var privateKey = params.privateKey;
var privateKey = params.credentials_private_key? params.credentials_private_key.password : params.privateKey;
var acceptVersion = params.version;
var insecure = params.insecure;
var proxy = params.proxy;
Expand Down Expand Up @@ -45,6 +45,9 @@ var getHeaders = function(query) {
} else if (timestamp.indexOf('-') > 0) {
timestamp = timestamp.substring(0,timestamp.indexOf('-'));
}
if (!privateKey){
throw('Private Key must be provided.')
}
message = query + acceptVersion + 'application/json' + timestamp;
hashed = HMAC_SHA256_MAC(privateKey, message);

Expand Down
8 changes: 7 additions & 1 deletion Packs/isight/Integrations/FireEyeISIGHT/FireEyeISIGHT.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,13 @@ configuration:
name: privateKey
defaultvalue: ""
type: 4
required: true
required: false
hidden: true
- displaypassword: Private Key
name: credentials_private_key
required: false
hiddenusername: true
type: 9
- display: Version
name: version
defaultvalue: "2.5"
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## FireEye iSIGHT
FireEye iSIGHT is a cybersecurity intelligence platform that provides organizations with comprehensive threat intelligence and analysis.
It offers real-time monitoring and detection of emerging cyber threats, allowing businesses to proactively defend against attacks.
133 changes: 133 additions & 0 deletions Packs/isight/Integrations/FireEyeISIGHT/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,133 @@

### ip

***
basic search reports by ip

#### Base Command

`ip`

#### Input

| **Argument Name** | **Description** | **Required** |
| --- | --- | --- |
| ip | ip to search by. | Required |

#### Context Output

| **Path** | **Type** | **Description** |
| --- | --- | --- |
| DBotScore.Indicator | unknown | The indicator we tested |
| DBotScore.Type | unknown | The type of the indicator |
| DBotScore.Vendor | unknown | Vendor used to calculate the score |
| DBotScore.Score | unknown | The actual score |
| IP.Address | unknown | The IP address |
| Report.ID | unknown | Report ID |
| Report.title | unknown | Report title |
| Report.publishDate | unknown | Report publish date |
| Report.intelligenceType | unknown | Report intelligence type \(overview, vulnerability, malware, threat\) |
### domain

***
basic search reports by domain

#### Base Command

`domain`

#### Input

| **Argument Name** | **Description** | **Required** |
| --- | --- | --- |
| domain | domain to search by. | Required |

#### Context Output

| **Path** | **Type** | **Description** |
| --- | --- | --- |
| DBotScore.Indicator | unknown | The indicator we tested |
| DBotScore.Type | unknown | The type of the indicator |
| DBotScore.Vendor | unknown | Vendor used to calculate the score |
| DBotScore.Score | unknown | The actual score |
| Domain.Name | unknown | The domain name. |
| Report.ID | unknown | Report ID |
| Report.title | unknown | Report title |
| Report.publishDate | unknown | Report publish date |
| Report.intelligenceType | unknown | Report intelligence type \(overview, vulnerability, malware, threat\) |
### file

***
basic search file report by md5/sha1. NOTE - specify only one of md5/sha1 arguments

#### Base Command

`file`

#### Input

| **Argument Name** | **Description** | **Required** |
| --- | --- | --- |
| file | md5 or sha1 to search by. | Optional |

#### Context Output

| **Path** | **Type** | **Description** |
| --- | --- | --- |
| DBotScore.Indicator | unknown | The indicator we tested |
| DBotScore.Type | unknown | The type of the indicator |
| DBotScore.Vendor | unknown | Vendor used to calculate the score |
| DBotScore.Score | unknown | The actual score |
| Report.ID | unknown | Report ID |
| Report.title | unknown | Report title |
| Report.publishDate | unknown | Report publish date |
| Report.intelligenceType | unknown | Report intelligence type \(overview, vulnerability, malware, threat\) |
### isight-get-report

***
Get specific report

#### Base Command

`isight-get-report`

#### Input

| **Argument Name** | **Description** | **Required** |
| --- | --- | --- |
| reportID | Report ID to search by. | Required |

#### Context Output

| **Path** | **Type** | **Description** |
| --- | --- | --- |
| Report.ID | unknown | Report ID |
| Report.title | unknown | Report title |
| Report.publishDate | unknown | Report publish date |
| Report.intelligenceType | unknown | Report intelligence type \(overview, vulnerability, malware, threat\) |
| Report.audience | unknown | Report audience |
| Report.ThreatScape | unknown | Report threat scape |
| Report.operatingSystems | unknown | Report operating systems |
| Report.riskRating | unknown | Report risk rating |
| Report.version | unknown | Report version |
| Report.tagSection | unknown | Report tag section |
### isight-submit-file

***
Submission of malware and other files for community sharing

#### Base Command

`isight-submit-file`

#### Input

| **Argument Name** | **Description** | **Required** |
| --- | --- | --- |
| entryID | entry-id of the file to submit (e.g. 41@18). | Required |
| description | file description. | Required |
| type | Type of the given file. Possible values are: malware, other. | Required |

#### Context Output

There is no context output for this command.
5 changes: 5 additions & 0 deletions Packs/isight/ReleaseNotes/1_0_3.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@

#### Integrations

##### FireEye iSIGHT
Added the *Private Key* integration parameters to support credentials fetching object.
maimorag marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 1 addition & 1 deletion Packs/isight/pack_metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "FireEye iSIGHT",
"description": "FireEye cyber threat intelligence",
"support": "xsoar",
"currentVersion": "1.0.2",
"currentVersion": "1.0.3",
"author": "Cortex XSOAR",
"url": "https://www.paloaltonetworks.com/cortex",
"email": "",
Expand Down
3 changes: 2 additions & 1 deletion Tests/conf.json
Original file line number Diff line number Diff line change
Expand Up @@ -5751,7 +5751,8 @@
"LogRhythm": "The integration is deprecated",
"Threat Grid": "No instance & Depreceated, replaced by ThreatGridv2",
"ThreatGridv2": "No instance - developed by Qmasters",
"SentinelOne V2": "No instance - developed by partner"
"SentinelOne V2": "No instance - developed by partner",
"CheckPhish": "Issue CRTX-86562"
},
"nightly_packs": [
"CommonScripts",
Expand Down