Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

St zendesk private comments #27921

Merged
merged 7 commits into from
Jul 5, 2023
Merged

St zendesk private comments #27921

merged 7 commits into from
Jul 5, 2023

Conversation

Shellyber
Copy link
Contributor

Status

  • Ready

Description

Added the argument public to the following commands:

  • zendesk-ticket-create
  • zendesk-ticket-update

Screenshots

Paste here any images that will help the reviewer

Does it break backward compatibility?

  • No

Must have

  • Documentation

@@ -480,6 +481,7 @@ Required permissions: Agents.
| collaborators | Users to add as CCs when creating a ticket. | Optional |
| comment | A comment to add to the ticket. | Optional |
| html_comment | An HTML comment to add to the ticket. | Optional |
| public | true if a public comment; false if an internal note. The initial value set on ticket creation persists for any additional comment unless you change it. Possible values are: true, false. Default is true. | Optional |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment or note? what's the right term?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is from the api docs - comment will be the right term

@Shellyber Shellyber merged commit cf2f873 into master Jul 5, 2023
@Shellyber Shellyber deleted the st-zendesk-private-comments branch July 5, 2023 15:34
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Jul 26, 2023
* Added the public argument to ticket handling

* Added rn and bumped version

* Fixed default value in one of the commands

* Added the option also for html_comment

* Fixed small bug in args
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants