Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

St zendesk private comments #27921

Merged
merged 7 commits into from
Jul 5, 2023
Merged

St zendesk private comments #27921

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
157f6d3
Added the public argument to ticket handling
Shellyber Jul 4, 2023
4223ede
Added rn and bumped version
Shellyber Jul 4, 2023
c0e105b
Fixed default value in one of the commands
Shellyber Jul 4, 2023
415de14
Merge branch 'master' into st-zendesk-private-comments
Shellyber Jul 5, 2023
463a742
Added the option also for html_comment
Shellyber Jul 5, 2023
e7f88e0
Merge branch 'master' into st-zendesk-private-comments
Shellyber Jul 5, 2023
ee03df5
Fixed small bug in args
Shellyber Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Packs/Zendesk/Integrations/Zendeskv2/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,6 +414,7 @@ Required permissions: Agents.
| brand_id | Enterprise only. The ID of the brand this ticket is associated with. | Optional |
| comment | A comment to add to the ticket. | Optional |
| html_comment | An HTML comment to add to the ticket. | Optional |
| public | true if a public comment; false if an internal note. The initial value set on ticket creation persists for any additional comment unless you change it. Possible values are: true, false. Default is true. | Optional |


#### Context Output
Expand Down Expand Up @@ -480,6 +481,7 @@ Required permissions: Agents.
| collaborators | Users to add as CCs when creating a ticket. | Optional |
| comment | A comment to add to the ticket. | Optional |
| html_comment | An HTML comment to add to the ticket. | Optional |
| public | true if a public comment; false if an internal note. The initial value set on ticket creation persists for any additional comment unless you change it. Possible values are: true, false. Default is true. | Optional |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment or note? what's the right term?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is from the api docs - comment will be the right term

| recipient | The original recipient email address of the ticket. | Optional |
| status | The state of the ticket. Possible values are: open, pending, hold, solved, closed. | Optional |
| priority | The urgency with which the ticket should be addressed. Possible values are: urgent, high, normal, low. | Optional |
Expand Down
2 changes: 2 additions & 0 deletions Packs/Zendesk/Integrations/Zendeskv2/Zendeskv2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,6 +647,8 @@ def __init__(self, type: Optional[str] = None, collaborators: Optional[str] = No
self._data['comment']['public'] = argToBoolean(public)
if html_comment:
self._data['comment'] = {'html_body': html_comment}
if public:
self._data['comment']['public'] = argToBoolean(public)
if status:
Validators.validate_ticket_status(status)
self._data['status'] = status
Expand Down
14 changes: 14 additions & 0 deletions Packs/Zendesk/Integrations/Zendeskv2/Zendeskv2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1045,6 +1045,13 @@ script:
description: A comment to add to the ticket.
- name: html_comment
description: An HTML comment to add to the ticket.
- name: public
description: true if a public comment; false if an internal note. The initial value set on ticket creation persists for any additional comment unless you change it.
defaultValue: 'true'
auto: PREDEFINED
predefined:
- 'true'
- 'false'
- name: collaborators
isArray: true
description: Users to add as CC's when creating a ticket.
Expand Down Expand Up @@ -1242,6 +1249,13 @@ script:
description: A comment to add to the ticket.
- name: html_comment
description: An HTML comment to add to the ticket.
- name: public
description: true if a public comment; false if an internal note. The initial value set on ticket creation persists for any additional comment unless you change it.
defaultValue: 'true'
auto: PREDEFINED
predefined:
- 'true'
- 'false'
- name: recipient
description: The original recipient email address of the ticket.
- name: status
Expand Down
8 changes: 8 additions & 0 deletions Packs/Zendesk/ReleaseNotes/2_1_1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@

#### Integrations

##### Zendesk v2

Added the argument *public* to the following commands:
- ***zendesk-ticket-create***
- ***zendesk-ticket-update***
2 changes: 1 addition & 1 deletion Packs/Zendesk/pack_metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "Zendesk",
"description": "IT service management",
"support": "xsoar",
"currentVersion": "2.1.0",
"currentVersion": "2.1.1",
"author": "Cortex XSOAR",
"url": "https://www.paloaltonetworks.com/cortex",
"email": "",
Expand Down