[Marketplace Contribution] Cisco Umbrella cloud security - Content Pack Update #32939

xsoar-bot · 2024-02-14T15:38:54Z

Warning
The changes in the contributed files were not made on the most updated pack versions

Item Name Contribution Pack Version Latest Pack Version

Cisco Umbrella Cloud Security v2 2.0.6 2.0.7

For the Reviewer:

Compare the code of this PR with the latest version of the pack. Make sure you understand the changes the contributor intended to contribute, and solve the conflicts accordingly.

In case improvements are needed, instruct the contributor to edit the code through the GitHub Codespaces and Not through the XSOAR UI.

For the Contributor:
@randomizerxd
In case you are requested by your reviewer to improve the code or to make changes, submit them through the GitHub Codespaces and Not through the XSOAR UI.

To use the GitHub Codespaces, do the following:

Click the 'Code' button in the right upper corner of this PR.

Click 'Create codespace on Transformers'.

Click 'Authorize and continue'.

Wait until your Codespace environment is generated. When it is, you can edit your code.

Commit and push your changes to the head branch of the PR.

Status

In Progress
Ready
In Hold - (Reason for hold)

Contributor

@randomizerxd

Video Link

Short demo video of the Pack usage. Speeds up the review. Optional but recommended. Use a video sharing service such as Google Drive or YouTube.

content-bot · 2024-02-14T15:40:36Z

Thank you for your contribution. Your generosity and caring are unrivaled! Rest assured - our content wizard @shmuel44 will very shortly look over your proposed changes.
For your convenience, here is a link to the contributions SLAs document.

content-bot · 2024-02-14T15:40:37Z

Thanks for contributing to a Cortex XSOAR supported pack. To receive credit for your generous contribution, please ask the reviewer to update your information in the pack contributors file. See more information here link

randomizerxd

Finished my review. Let me know if other changes are required.

randomizerxd · 2024-02-14T15:45:57Z

...la-cloud-security/Integrations/CiscoUmbrellaCloudSecurityv2/CiscoUmbrellaCloudSecurityv2.yml

@@ -29,27 +29,18 @@ script:
    - name: destination_list_id
      description: The ID of the destination list. Destination lists can be fetched with the `umbrella-destination-lists-list` command.
      required: true
-      isArray: false


I did not intentionally move all of these isArray and required. Do you want me to add them back in?

it's fine, it could be a result of running the format command, you can keep them.

merit-maita

Thank you for your contribution!
please see my comments, and check the failing check in the pr, it's failing with the unit tests coverage, so please make sure to add unit tests, if you need help, please let me know.

merit-maita · 2024-02-18T12:46:53Z

...lla-cloud-security/Integrations/CiscoUmbrellaCloudSecurityv2/CiscoUmbrellaCloudSecurityv2.py

+                    resp_type='response',
+                    ok_codes=(200, 201, 401)
+                )
+                try:
+                    res = res.json()
+                except ValueError as exception:
+                    raise DemistoException('Failed to parse json object from response: {}'.format(res.content),
+                                           exception)
+                if 'error' in res:
+                    return_error(
+                        f'Error occurred while creating an access token. Please check the API key and secret '
+                        f'and try to run the login command again to generate a new access token as it '
+                        f'might have expired.\n{res}')


no need to provide ok_codes list, 200s status codes are always okay, and 401, is being handled in the test-module command.
for the response type, no need to set it to be response, it's set to be json by default in the http_request function, which also performs the steps done in lines 110 - 119.
in conclusion, for follow up our code writing practice:

please remove the resp_type and okay_codes params in calling the _http_request method.

remove the 110 -119 lines as well.

I copied this from the ServiceNow v2 integration source code get_access_token function. Okay, I made those changes.

merit-maita · 2024-02-18T12:47:55Z

...la-cloud-security/Integrations/CiscoUmbrellaCloudSecurityv2/CiscoUmbrellaCloudSecurityv2.yml

@@ -29,27 +29,18 @@ script:
    - name: destination_list_id
      description: The ID of the destination list. Destination lists can be fetched with the `umbrella-destination-lists-list` command.
      required: true
-      isArray: false


it's fine, it could be a result of running the format command, you can keep them.

Packs/Cisco-umbrella-cloud-security/ReleaseNotes/2_1_0.md

Packs/Cisco-umbrella-cloud-security/pack_metadata.json

Co-authored-by: merit-maita <49760643+merit-maita@users.noreply.github.com>

merit-maita

see my comments please

...loud-security/Integrations/CiscoUmbrellaCloudSecurityv2/CiscoUmbrellaCloudSecurityv2_test.py

merit-maita · 2024-02-21T12:31:12Z

...loud-security/Integrations/CiscoUmbrellaCloudSecurityv2/CiscoUmbrellaCloudSecurityv2_test.py

+    - Ensure that an access token is returned
+    """
+
+    response = load_mock_response('token.json')


no need to add it as a file since it's a small test, define the response as the dict inside the token_json.

Okay, I deleted token.json and added the dict within the function

...loud-security/Integrations/CiscoUmbrellaCloudSecurityv2/CiscoUmbrellaCloudSecurityv2_test.py

Co-authored-by: merit-maita <49760643+merit-maita@users.noreply.github.com>

test_get_access_token() - token.json deleted, so provided response dict containing access_token within function updated "When" docstrings of all test functions

…la-cloud-security' into randomizerxd-contrib-Cisco-umbrella-cloud-security

…CloudSecurityv2/test_data/token.json

…ck Update (#33070) * [Marketplace Contribution] Cisco Umbrella cloud security - Content Pack Update (#32939) * "contribution update to pack "Cisco Umbrella cloud security"" * Revert description * remove try/except around get_access_token call * removed resp_type and ok_codes arguments passed to _http_request * currentVersion to 2.0.8 Co-authored-by: merit-maita <49760643+merit-maita@users.noreply.github.com> * Update Packs/Cisco-umbrella-cloud-security/ReleaseNotes/2_1_0.md Co-authored-by: merit-maita <49760643+merit-maita@users.noreply.github.com> * Rename 2_1_0.md to 2_0_8.md * add test_get_access_token * Create token.json * Apply suggestions from code review Co-authored-by: merit-maita <49760643+merit-maita@users.noreply.github.com> * provide access_token dict and update docstrings test_get_access_token() - token.json deleted, so provided response dict containing access_token within function updated "When" docstrings of all test functions * revert * Delete Packs/Cisco-umbrella-cloud-security/Integrations/CiscoUmbrellaCloudSecurityv2/test_data/token.json * update currentVersion to 2.0.9 * Create 2_0_9.md --------- Co-authored-by: Randy Baldwin <32545292+randomizerxd@users.noreply.github.com> Co-authored-by: merit-maita <49760643+merit-maita@users.noreply.github.com> * fixed lint errors --------- Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com> Co-authored-by: Randy Baldwin <32545292+randomizerxd@users.noreply.github.com> Co-authored-by: merit-maita <49760643+merit-maita@users.noreply.github.com> Co-authored-by: merit-maita <meretmaayta@gmail.com>

"contribution update to pack "Cisco Umbrella cloud security""

d1937db

content-bot added Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Feb 14, 2024

content-bot changed the base branch from master to contrib/xsoar-contrib_randomizerxd-contrib-Cisco-umbrella-cloud-security February 14, 2024 15:40

content-bot assigned shmuel44 Feb 14, 2024

content-bot requested a review from shmuel44 February 14, 2024 15:40

Revert description

0fee3db

randomizerxd approved these changes Feb 14, 2024

View reviewed changes

remove try/except around get_access_token call

905a629

shmuel44 requested review from JudahSchwartz and removed request for shmuel44 February 16, 2024 11:54

shmuel44 assigned JudahSchwartz and unassigned shmuel44 Feb 16, 2024

JudahSchwartz assigned merit-maita and unassigned JudahSchwartz Feb 18, 2024

JudahSchwartz requested review from merit-maita and removed request for JudahSchwartz February 18, 2024 07:58

merit-maita requested changes Feb 18, 2024

View reviewed changes

merit-maita added the pending-contributor The PR is pending the response of its creator label Feb 18, 2024

randomizerxd and others added 6 commits February 19, 2024 10:53

removed resp_type and ok_codes arguments passed to _http_request

d7fb622

currentVersion to 2.0.8

3303ae1

Co-authored-by: merit-maita <49760643+merit-maita@users.noreply.github.com>

Update Packs/Cisco-umbrella-cloud-security/ReleaseNotes/2_1_0.md

d70ea6e

Co-authored-by: merit-maita <49760643+merit-maita@users.noreply.github.com>

Rename 2_1_0.md to 2_0_8.md

c6278f8

add test_get_access_token

292749f

Create token.json

f096977

merit-maita reviewed Feb 21, 2024

View reviewed changes

Apply suggestions from code review

eb3af1f

Co-authored-by: merit-maita <49760643+merit-maita@users.noreply.github.com>

randomizerxd added 6 commits February 21, 2024 09:15

provide access_token dict and update docstrings

885b741

test_get_access_token() - token.json deleted, so provided response dict containing access_token within function updated "When" docstrings of all test functions

Merge branch 'contrib/xsoar-contrib_randomizerxd-contrib-Cisco-umbrel…

aa1aa83

…la-cloud-security' into randomizerxd-contrib-Cisco-umbrella-cloud-security

revert

cd5c71e

Delete Packs/Cisco-umbrella-cloud-security/Integrations/CiscoUmbrella…

48921c8

…CloudSecurityv2/test_data/token.json

update currentVersion to 2.0.9

0d166f2

Create 2_0_9.md

9893861

merit-maita approved these changes Feb 22, 2024

View reviewed changes

merit-maita merged commit 012ab61 into demisto:contrib/xsoar-contrib_randomizerxd-contrib-Cisco-umbrella-cloud-security Feb 22, 2024
12 of 21 checks passed

content-bot mentioned this pull request Feb 22, 2024

[Marketplace Contribution] Cisco Umbrella cloud security - Content Pack Update #33070

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Marketplace Contribution] Cisco Umbrella cloud security - Content Pack Update #32939

[Marketplace Contribution] Cisco Umbrella cloud security - Content Pack Update #32939

xsoar-bot commented Feb 14, 2024

content-bot commented Feb 14, 2024

content-bot commented Feb 14, 2024

randomizerxd left a comment

randomizerxd Feb 14, 2024

merit-maita Feb 18, 2024

merit-maita left a comment

merit-maita Feb 18, 2024

randomizerxd Feb 19, 2024

merit-maita Feb 18, 2024

merit-maita left a comment

merit-maita Feb 21, 2024

randomizerxd Feb 21, 2024

[Marketplace Contribution] Cisco Umbrella cloud security - Content Pack Update #32939

[Marketplace Contribution] Cisco Umbrella cloud security - Content Pack Update #32939

Conversation

xsoar-bot commented Feb 14, 2024

Status

Contributor

Video Link

content-bot commented Feb 14, 2024

content-bot commented Feb 14, 2024

randomizerxd left a comment

Choose a reason for hiding this comment

randomizerxd Feb 14, 2024

Choose a reason for hiding this comment

merit-maita Feb 18, 2024

Choose a reason for hiding this comment

merit-maita left a comment

Choose a reason for hiding this comment

merit-maita Feb 18, 2024

Choose a reason for hiding this comment

randomizerxd Feb 19, 2024

Choose a reason for hiding this comment

merit-maita Feb 18, 2024

Choose a reason for hiding this comment

merit-maita left a comment

Choose a reason for hiding this comment

merit-maita Feb 21, 2024

Choose a reason for hiding this comment

randomizerxd Feb 21, 2024

Choose a reason for hiding this comment