Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Marketplace Contribution] Cisco Umbrella cloud security - Content Pack Update #33070

Merged
merged 3 commits into from
Feb 28, 2024
Merged

[Marketplace Contribution] Cisco Umbrella cloud security - Content Pack Update #33070

merged 3 commits into from
Feb 28, 2024

Conversation

content-bot
Copy link
Collaborator

Original External PR

external pull request

Warning
The changes in the contributed files were not made on the most updated pack versions

Item Name Contribution Pack Version Latest Pack Version
Cisco Umbrella Cloud Security v2 2.0.6 2.0.7

For the Reviewer:

  1. Compare the code of this PR with the latest version of the pack. Make sure you understand the changes the contributor intended to contribute, and solve the conflicts accordingly.
  2. In case improvements are needed, instruct the contributor to edit the code through the GitHub Codespaces and Not through the XSOAR UI.

For the Contributor:
@randomizerxd
In case you are requested by your reviewer to improve the code or to make changes, submit them through the GitHub Codespaces and Not through the XSOAR UI.

To use the GitHub Codespaces, do the following:

  1. Click the 'Code' button in the right upper corner of this PR.
  2. Click 'Create codespace on Transformers'.
  3. Click 'Authorize and continue'.
  4. Wait until your Codespace environment is generated. When it is, you can edit your code.
  5. Commit and push your changes to the head branch of the PR.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Contributor

@randomizerxd

Video Link

Short demo video of the Pack usage. Speeds up the review. Optional but recommended. Use a video sharing service such as Google Drive or YouTube.

@xsoar-bot @randomizerxd @merit-maita
[Marketplace Contribution] Cisco Umbrella cloud security - Content Pa…
012ab61 
…ck Update (#32939)

* "contribution update to pack "Cisco Umbrella cloud security""

* Revert description

* remove try/except around get_access_token call

* removed resp_type and ok_codes arguments passed to _http_request

* currentVersion to 2.0.8

Co-authored-by: merit-maita <49760643+merit-maita@users.noreply.github.com>

* Update Packs/Cisco-umbrella-cloud-security/ReleaseNotes/2_1_0.md

Co-authored-by: merit-maita <49760643+merit-maita@users.noreply.github.com>

* Rename 2_1_0.md to 2_0_8.md

* add test_get_access_token

* Create token.json

* Apply suggestions from code review

Co-authored-by: merit-maita <49760643+merit-maita@users.noreply.github.com>

* provide access_token dict and update docstrings

test_get_access_token() - token.json deleted, so provided response dict containing access_token within function

updated "When" docstrings of all test functions

* revert

* Delete Packs/Cisco-umbrella-cloud-security/Integrations/CiscoUmbrellaCloudSecurityv2/test_data/token.json

* update currentVersion to 2.0.9

* Create 2_0_9.md

---------

Co-authored-by: Randy Baldwin <32545292+randomizerxd@users.noreply.github.com>
Co-authored-by: merit-maita <49760643+merit-maita@users.noreply.github.com>
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! pending-contributor The PR is pending the response of its creator Xsoar Support Level Indicates that the contribution is for XSOAR supported pack Internal PR labels Feb 22, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 22, 2024 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/Cisco-umbrella-cloud-security/Integrations/CiscoUmbrellaCloudSecurityv2
   CiscoUmbrellaCloudSecurityv2.py2565379%87–88, 98, 117–118, 138, 355–358, 360, 382, 399, 462–465, 477–478, 529, 595–596, 877–878, 880–882, 884, 886, 890–892, 894–897, 899, 901, 911, 920–921, 929–936, 938, 940, 942–943
TOTAL2565379% 

Tests Skipped Failures Errors Time
10 0 💤 0 ❌ 0 🔥 1.701s ⏱️

@merit-maita merit-maita merged commit 716e44f into master Feb 28, 2024
17 checks passed
@merit-maita merit-maita deleted the contrib/xsoar-contrib_randomizerxd-contrib-Cisco-umbrella-cloud-security branch February 28, 2024 13:51
maimorag pushed a commit that referenced this pull request Feb 28, 2024
@content-bot @xsoar-bot
@randomizerxd @merit-maita @maimorag
[Marketplace Contribution] Cisco Umbrella cloud security - Content Pa…
8f69ed6 
…ck Update (#33070)

* [Marketplace Contribution] Cisco Umbrella cloud security - Content Pack Update (#32939)

* "contribution update to pack "Cisco Umbrella cloud security""

* Revert description

* remove try/except around get_access_token call

* removed resp_type and ok_codes arguments passed to _http_request

* currentVersion to 2.0.8

Co-authored-by: merit-maita <49760643+merit-maita@users.noreply.github.com>

* Update Packs/Cisco-umbrella-cloud-security/ReleaseNotes/2_1_0.md

Co-authored-by: merit-maita <49760643+merit-maita@users.noreply.github.com>

* Rename 2_1_0.md to 2_0_8.md

* add test_get_access_token

* Create token.json

* Apply suggestions from code review

Co-authored-by: merit-maita <49760643+merit-maita@users.noreply.github.com>

* provide access_token dict and update docstrings

test_get_access_token() - token.json deleted, so provided response dict containing access_token within function

updated "When" docstrings of all test functions

* revert

* Delete Packs/Cisco-umbrella-cloud-security/Integrations/CiscoUmbrellaCloudSecurityv2/test_data/token.json

* update currentVersion to 2.0.9

* Create 2_0_9.md

---------

Co-authored-by: Randy Baldwin <32545292+randomizerxd@users.noreply.github.com>
Co-authored-by: merit-maita <49760643+merit-maita@users.noreply.github.com>

* fixed lint errors

---------

Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com>
Co-authored-by: Randy Baldwin <32545292+randomizerxd@users.noreply.github.com>
Co-authored-by: merit-maita <49760643+merit-maita@users.noreply.github.com>
Co-authored-by: merit-maita <meretmaayta@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merit-maita merit-maita merit-maita approved these changes

Assignees

@merit-maita merit-maita

Labels
Contribution Thank you! Contributions are always welcome! docs-approved Internal PR pending-contributor The PR is pending the response of its creator Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@content-bot @merit-maita @xsoar-bot