Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ST110 - StrictAssetsModelingRuleSchema #4519

Merged
merged 7 commits into from
Sep 8, 2024
Merged

ST110 - StrictAssetsModelingRuleSchema #4519

merged 7 commits into from
Sep 8, 2024

Conversation

rshunim
Copy link
Contributor

@rshunim rshunim commented Aug 25, 2024

Related Issues

relates: https://jira-dc.paloaltonetworks.com/browse/CIAC-7809

Description

Add StrictAssetsModelingRuleSchema pydantic object for ST110 validation

@rshunim rshunim requested a review from dorschw August 25, 2024 15:14
@rshunim rshunim self-assigned this Aug 25, 2024
@github-actions GitHub Actions
Copy link

Changelog(s) in markdown:

  • Added 'AssetsModelingRuleSchema' to the ST110 validation. #4519

@rshunim
Copy link
Contributor Author

rshunim commented Aug 25, 2024

I checked the new feature on ModelingRule Directory.
I also changed the json schema file for catching errors and it works as expected.

dorschw
dorschw reviewed Sep 5, 2024
View reviewed changes
Copy link
Contributor

@dorschw dorschw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, please add a unit test since this isn't a standard ST110 case

demisto_sdk/commands/content_graph/strict_objects/assets_modeling_rule_schema.py


class StrictAssetsModelingRuleSchema(BaseStrictModel):
__root__: Optional[Dict[constr(regex=r".+"), Dict[str, AssetType]]] = None # type:ignore[valid-type]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r".+" means a string that isn't empty?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, since the field can be everything
as it allows in the schema file

@rshunim rshunim requested a review from dorschw September 5, 2024 11:46
rshunim and others added 3 commits September 8, 2024 14:31
@rshunim @dorschw
Update demisto_sdk/commands/validate/tests/ST_validators_test.py
89a4845 
Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>
@rshunim @dorschw
Update demisto_sdk/commands/validate/tests/ST_validators_test.py
6d0d2bd 
Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>
@rshunim
pre commit
15f3610
@rshunim rshunim merged commit a8e4357 into master Sep 8, 2024
25 checks passed
@rshunim rshunim deleted the assets_modeling_rule_schema_pydantic branch September 8, 2024 12:08
@RosenbergYehuda RosenbergYehuda mentioned this pull request Sep 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorschw dorschw dorschw approved these changes

Assignees

@rshunim rshunim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rshunim @dorschw