-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ST110 - StrictAssetsModelingRuleSchema #4519
Merged
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e21c636
add StrictAssetsModelingRuleSchema for ST110
rshunim 186800f
RN
rshunim fc710f1
add UTs for ModelingRuleParser
rshunim 8d45f68
Merge branch 'master' into assets_modeling_rule_schema_pydantic
rshunim 89a4845
Update demisto_sdk/commands/validate/tests/ST_validators_test.py
rshunim 6d0d2bd
Update demisto_sdk/commands/validate/tests/ST_validators_test.py
rshunim 15f3610
pre commit
rshunim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
changes: | ||
- description: Added 'AssetsModelingRuleSchema' to the `ST110` validation. | ||
type: feature | ||
pr_number: 4519 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
demisto_sdk/commands/content_graph/strict_objects/assets_modeling_rule_schema.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
from typing import Dict, Literal, Optional | ||
|
||
from pydantic import Field, constr | ||
|
||
from demisto_sdk.commands.content_graph.strict_objects.common import BaseStrictModel | ||
|
||
|
||
class AssetType(BaseStrictModel): | ||
type: Literal["string", "int", "float", "datetime", "boolean"] = Field( | ||
description="Type of the asset" | ||
) | ||
is_array: bool = Field(description="Whether the asset is an array") | ||
|
||
|
||
class StrictAssetsModelingRuleSchema(BaseStrictModel): | ||
__root__: Optional[Dict[constr(regex=r".+"), Dict[str, AssetType]]] = None # type:ignore[valid-type] | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r".+"
means a string that isn't empty?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, since the field can be everything
as it allows in the schema file