Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Docusaurus #19395

Closed
hashrock opened this issue Jun 7, 2023 · 6 comments · Fixed by #23202
Closed

Support Docusaurus #19395

hashrock opened this issue Jun 7, 2023 · 6 comments · Fixed by #23202
Assignees
Labels
node API Related to various "node:*" modules APIs node compat

Comments

@hashrock
Copy link
Contributor

hashrock commented Jun 7, 2023

Tracking issue for supporting Docusaurus

with docusaurus build :

  • error: Uncaught Error: Not implemented: Script.prototype.runInNewContext
@valpackett
Copy link

TiddlyWiki also uses runInNewContext

@bartlomieju bartlomieju self-assigned this Jun 28, 2023
@gabrielstuff
Copy link

hello and thanks for Deno and the Deno team.
Trying to play with https://esm.sh/ytdl-core@4.11.5 ends up with error: Uncaught (in promise)

Error: Not implemented: Script.prototype.runInNewContext
    at notImplemented (ext:deno_node/_utils.ts:9:11)
    at Script.runInNewContext (node:vm:22:9)
    at i (https://esm.sh/v130/ytdl-core@4.11.5/denonext/ytdl-core.mjs:12:25509)
    at Object.w.setDownloadURL (https://esm.sh/v130/ytdl-core@4.11.5/denonext/ytdl-core.mjs:12:25604)
    at https://esm.sh/v130/ytdl-core@4.11.5/denonext/ytdl-core.mjs:12:25825
    at Array.forEach (<anonymous>)
    at Object.w.decipherFormats (https://esm.sh/v130/ytdl-core@4.11.5/denonext/ytdl-core.mjs:12:25811)
    at Object.runMicrotasks (ext:core/01_core.js:838:30)
    at processTicksAndRejections (ext:deno_node/_next_tick.ts:53:14)
    at runNextTicks (ext:deno_node/_next_tick.ts:71:5)

It feels like the issue is mostly related to runInNewContext not being implemented.

How can we help on that ?

@bartlomieju
Copy link
Member

Sorry for a late reply. Getting Script.runInNewContext requires lots of work that entails porting https://github.com/nodejs/node/blob/main/src/node_contextify.cc using Rust APIs. This is a very non-trivial undertaking and the Deno team is planning to address this in Q4 2023.

@bartlomieju
Copy link
Member

#21527 will be a step towards supporting this, but most likely not enough (as the PR doesn't support any options).

@bartlomieju bartlomieju removed their assignment Mar 4, 2024
@bartlomieju bartlomieju added the node API Related to various "node:*" modules APIs label Mar 4, 2024
@littledivy
Copy link
Member

runInNewContext is not an error anymore. These are the next blockers:

@littledivy
Copy link
Member

docusaurus serve works now. Let's track the remaining CLI and docusaurus build issues seperately.

#22732
#23297

satyarohith pushed a commit that referenced this issue Apr 11, 2024
Implement contextified objects in `node:vm`

Fixes #23186
Fixes #22395
Fixes #20607
Fixes #18299
Fixes #19395
Fixes #18315
Fixes #18319
Fixes #23183
littledivy added a commit to littledivy/deno that referenced this issue Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node API Related to various "node:*" modules APIs node compat
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants