fix(ext/node): node:vm contexts
#23202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littledivy
commented
Apr 3, 2024
bartlomieju
requested changes
Apr 7, 2024
|
Can we add an integration test that ensures we don't leak memory when |
littledivy
changed the title
node:vm contextsnode:vm contexts
bartlomieju
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
LGTM, but I asked @mmastrac for second pair of eyes to review
satyarohith
pushed a commit
that referenced
this pull request
Apr 11, 2024
littledivy
added a commit
to littledivy/deno
that referenced
this pull request
Apr 19, 2024
Implement contextified objects in `node:vm` Fixes denoland#23186 Fixes denoland#22395 Fixes denoland#20607 Fixes denoland#18299 Fixes denoland#19395 Fixes denoland#18315 Fixes denoland#18319 Fixes denoland#23183
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement contextified objects in
node:vmFixes #23186
Fixes #22395
Fixes #20607
Fixes #18299
Fixes #19395
Fixes #18315
Fixes #18319
Fixes #23183