Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement TransformStream cleanup using "transformer.cancel" #20741

Closed
lucacasonato opened this issue Sep 30, 2023 · 0 comments · Fixed by #20815
Closed

Implement TransformStream cleanup using "transformer.cancel" #20741

lucacasonato opened this issue Sep 30, 2023 · 0 comments · Fixed by #20815
Labels
ext/web related to the ext/web crate feat new feature (which has been agreed to/accepted)

Comments

@lucacasonato
Copy link
Member

The Streams specification has been updated with support for a hook to cleanup a TransformStream on error / abort. See whatwg/streams#1283. WPTs are available: web-platform-tests/wpt#40453
@lucacasonato lucacasonato added feat new feature (which has been agreed to/accepted) ext/web related to the ext/web crate labels Sep 30, 2023
@lucacasonato lucacasonato mentioned this issue Sep 30, 2023
Merged
4 tasks
@lucacasonato lucacasonato changed the title Implement TransformStream cleanup using "transformer.cleanup" Implement TransformStream cleanup using "transformer.cancel" Sep 30, 2023
@lucacasonato lucacasonato mentioned this issue Oct 6, 2023
Merged
@crowlKats crowlKats mentioned this issue Nov 3, 2023
Merged
@egfx-notifications egfx-notifications mentioned this issue Nov 14, 2023
Merged
mmastrac pushed a commit that referenced this issue Feb 13, 2024
@egfx-notifications
fix(ext/web): Prevent (De-)CompressionStream resource leak on stream …
082f812 
…cancellation (#21199)

Based on #21074 and #20741 I was looking for further potential use cases
of `TransformStream` `cancel()` method, so here go `CompressionStream`
and `DecompressionStream`.

Fixes #14212
littledivy pushed a commit that referenced this issue Feb 15, 2024
@egfx-notifications @littledivy
fix(ext/web): Prevent (De-)CompressionStream resource leak on stream …
24af5a2 
…cancellation (#21199)

Based on #21074 and #20741 I was looking for further potential use cases
of `TransformStream` `cancel()` method, so here go `CompressionStream`
and `DecompressionStream`.

Fixes #14212
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ext/web related to the ext/web crate feat new feature (which has been agreed to/accepted)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ext/web): cancel support for TransformStream lucacasonato/deno
1 participant
@lucacasonato