Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ext/web): cancel support for TransformStream #20815

Merged
merged 2 commits into from
Oct 10, 2023
Merged

feat(ext/web): cancel support for TransformStream #20815

merged 2 commits into from
Oct 10, 2023

Conversation

lucacasonato
Copy link
Member

@lucacasonato lucacasonato commented Oct 6, 2023 •
edited
Loading

Fixes #20741

@lucacasonato lucacasonato marked this pull request as ready for review October 10, 2023 03:05
crowlKats
crowlKats approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucacasonato lucacasonato merged commit 6450334 into denoland:main Oct 10, 2023
@lucacasonato lucacasonato deleted the ts_cancel branch October 10, 2023 09:42
bartlomieju pushed a commit that referenced this pull request Oct 12, 2023
@lucacasonato @bartlomieju
feat(ext/web): cancel support for TransformStream (#20815)
44c8b0d
@KnorpelSenf
Copy link
Contributor

I had to look twice before I understood that you aren't actually cancelling your support for TransformStream.

Cool changes tho!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crowlKats crowlKats crowlKats approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement TransformStream cleanup using "transformer.cancel"
3 participants
@lucacasonato @KnorpelSenf @crowlKats