Allow imports of JSON #1065
Merged
Allow imports of JSON #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ry this is ready for review |
Closed
|
@ry ready for review again |
ry
approved these changes
Oct 31, 2018
| assertEqual(deps && deps.length, 0); | ||
| assert(factory != null); | ||
| const factoryResult = factory(); | ||
| assertEqual(factoryResult, { hello: "world", foo: "bar" }); |
ry
added a commit
to ry/deno
that referenced
this pull request
Nov 2, 2018
Slowdowns cold-boot benchmark: 0.5s -> 0.8s This reverts commit 2422e52.
ry
added a commit
to ry/deno
that referenced
this pull request
Nov 5, 2018
- Performance and stability improvements on all platforms. - Add repl (denoland#998) - Add deno.Buffer (denoland#1121) - Support cargo check (denoland#1128) - Upgrade Rust crates and Flatbuffers. (denoland#1145, denoland#1127) - Add helper to turn deno.Reader into async iterator (denoland#1130) - Add ability to load JSON as modules (denoland#1065) - Add deno.resources() (denoland#1119) - Add application/x-typescript mime type support (denoland#1111)
Merged
ry
added a commit
that referenced
this pull request
Nov 5, 2018
- Performance and stability improvements on all platforms. - Add repl (#998) - Add deno.Buffer (#1121) - Support cargo check (#1128) - Upgrade Rust crates and Flatbuffers. (#1145, #1127) - Add helper to turn deno.Reader into async iterator (#1130) - Add ability to load JSON as modules (#1065) - Add deno.resources() (#1119) - Add application/x-typescript mime type support (#1111)
This output : Would it be possible to support it in the future? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1048
This is a WIP PR for allowing the import of JSON as a module, which would include the ability to ensure its type safety in consuming code. This would allow:
config.json
{ "debug": true, "version": "1.0.0" }main.ts