resources op #1119
resources op #1119
Conversation
|
@ry I updated PR, however another problem surfaced. In |
|
@bartlomieju just compare before and after - perhaps there is a file that doesn't get closed in somewhere else in the tests - the purpose of this is to figure out about those things |
|
It seams it fails exactly for that reason on AppVeyor. Looks like |
|
ping @ry |
js/resources_test.ts
Outdated
| const conn = await deno.dial("tcp", addr); | ||
| const buf = new Uint8Array(1024); | ||
| await conn.read(buf); | ||
| conn.close(); |
There was a problem hiding this comment.
It's possible that the callback doesn't get called at all. Please add a counter which gets incremented in the callback, and check here
assertEqual(counter, 1)
Also you can remove await conn.read(buf); - I think that has no effect here.
There was a problem hiding this comment.
You were right about that, I reworked it to use await, let me know if it looks good.
- Performance and stability improvements on all platforms. - Add repl (denoland#998) - Add deno.Buffer (denoland#1121) - Support cargo check (denoland#1128) - Upgrade Rust crates and Flatbuffers. (denoland#1145, denoland#1127) - Add helper to turn deno.Reader into async iterator (denoland#1130) - Add ability to load JSON as modules (denoland#1065) - Add deno.resources() (denoland#1119) - Add application/x-typescript mime type support (denoland#1111)
- Performance and stability improvements on all platforms. - Add repl (#998) - Add deno.Buffer (#1121) - Support cargo check (#1128) - Upgrade Rust crates and Flatbuffers. (#1145, #1127) - Add helper to turn deno.Reader into async iterator (#1130) - Add ability to load JSON as modules (#1065) - Add deno.resources() (#1119) - Add application/x-typescript mime type support (#1111)
Ref #1117
Todo:
Resource