Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: wasm modules in core #14485

Closed
wants to merge 12 commits into from
Closed

WIP: wasm modules in core #14485

wants to merge 12 commits into from

Conversation

lucacasonato
Copy link
Member

No description provided.

@lucacasonato lucacasonato marked this pull request as draft May 4, 2022 18:02
@bartlomieju bartlomieju mentioned this pull request May 4, 2022
Merged
bartlomieju
bartlomieju reviewed May 4, 2022
View reviewed changes
core/modules.rs Outdated Show resolved Hide resolved
@bartlomieju bartlomieju mentioned this pull request May 5, 2022
Merged
This was referenced May 6, 2022
Closed
Closed
@stale
Copy link

stale bot commented Jul 10, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 10, 2022
@stale stale bot closed this Jul 21, 2022
@kitsonk kitsonk reopened this Jul 21, 2022
@stale stale bot removed the stale label Jul 21, 2022
@ayame113 ayame113 mentioned this pull request Aug 23, 2022
Closed
@stale
Copy link

stale bot commented Oct 21, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 21, 2022
@stale stale bot closed this Oct 28, 2022
@bartlomieju bartlomieju reopened this Oct 28, 2022
@stale stale bot removed the stale label Oct 28, 2022
aapoalas
aapoalas requested changes Mar 25, 2023
View reviewed changes
Copy link
Collaborator

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This draft presumably would require a sizable number of changes, especially in light of semi-recent deno_graph refactors etc. Is the expectation still that this will eventually be finished, or should this be closed in favour of a later, fresh start?

@bartlomieju
Copy link
Member

This was blocked by V8 APIs from the get-go. I'm gonna close this PR for now since there's some movement on the proposal in TC39, which would make V8 implement this properly without workarounds on our side.

@bartlomieju bartlomieju closed this Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju left review comments

@aapoalas aapoalas aapoalas requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucacasonato @bartlomieju @aapoalas @kitsonk