Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): add AssertedModuleType enum #14501

Merged
merged 10 commits into from
May 7, 2022

Conversation

bartlomieju
Copy link
Member

Towards #2552
Towards #14485

@bartlomieju bartlomieju requested a review from AaronO as a code owner May 5, 2022 18:18
@bartlomieju bartlomieju requested a review from lucacasonato May 5, 2022 18:18
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

core/bindings.rs Outdated Show resolved Hide resolved
core/bindings.rs Outdated Show resolved Hide resolved
core/modules.rs Outdated Show resolved Hide resolved
core/modules.rs Outdated Show resolved Hide resolved
@bartlomieju bartlomieju merged commit bcd8750 into denoland:main May 7, 2022
piscisaureus pushed a commit that referenced this pull request May 12, 2022
Co-authored-by: Luca Casonato <hello@lcas.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants