fix(ext/flash): Fix request object returning uri property correctly after websocket upgrade #18519
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this is what's happening using the example from #18490
open
event is emitted after websocket upgraded is executed https://github.com/denoland/deno/blob/main/ext/flash/01_http.js#L435, therefore onopen
callbacks are executed laterrequest.uri
option insideopen
callback, it is lazy loaded via this function https://github.com/denoland/deno/blob/main/ext/flash/01_http.js#L574 which requires request with token 0 in the server context which was removed on step 2. Thus panic.This PR fixes this issue by preloading path before executing flash request.
Closes #18490