feat(ext/http): add an op to perform raw HTTP upgrade #18511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmastrac
changed the title
bartlomieju
reviewed
Apr 1, 2023
|
In #18552 I was able to completely refactor "ext/node" to not rely on Flash server impl and instead use "Deno.serveHttp" with the API provided in this PR. I think we should proceed with it, especially since we don't need to expose it as a public API. |
bartlomieju
changed the title
Closed
levex
pushed a commit
that referenced
this pull request
Apr 12, 2023
This commit adds new "op_http_upgrade_early", that allows to hijack existing "Deno.HttpConn" acquired from "Deno.serveHttp" API and performing a Websocket upgrade on this connection. This is not a public API and is meant to be used internally in the "ext/node" polyfills for "http" module. --------- Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds new "op_http_upgrade_early", that allows to hijack existing
"Deno.HttpConn" acquired from "Deno.serveHttp" API and performing
a Websocket upgrade on this connection.
This is not a public API and is meant to be used internally in the "ext/node"
polyfills for "http" module.