refactor(ext/node): migrate "http" module to use "Deno.serveHttp" API #18552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
bartlomieju
changed the title
mmastrac
reviewed
Apr 2, 2023
Comment on lines
+673
to
+686
| if (req.upgrade && this.listenerCount("upgrade") > 0) { | ||
| const conn = await denoHttp.upgradeHttpRaw( | ||
| reqEvent.request, | ||
| tcpConn, | ||
| ) as Deno.Conn; | ||
| const socket = new Socket({ | ||
| handle: new TCP(constants.SERVER, conn), | ||
| }); | ||
| this.emit("upgrade", req, socket, Buffer.from([])); | ||
| return; | ||
| } else { | ||
| const res = new ServerResponse(reqEvent); | ||
| this.emit("request", req, res); | ||
| } |
There was a problem hiding this comment.
Looks great. Is there an immutable node buffer we can use to avoid allocating? It's only on connection so probably isn't a huge deal.
There was a problem hiding this comment.
I'm not sure about that. Are you talking about the Buffer.from([])?
mmastrac
approved these changes
Apr 2, 2023
levex
pushed a commit
that referenced
this pull request
Apr 12, 2023
…#18552) This commit changes "node:http" module to use "Deno.serveHttp" API instead of "Deno.serve" API. --------- Co-authored-by: Matt Mastracci <matthew@mastracci.com>
bartlomieju
added a commit
to bartlomieju/deno
that referenced
this pull request
Apr 26, 2023
…ttp" API (denoland#18552)" This reverts commit 3cd7abf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes "node:http" module to use "Deno.serveHttp" API instead of
"Deno.serve" API. This allows us to migrate "Deno.serve" API to use "Deno.serveHttp"
under the hood and by extension allows us to remove the "flash" server implementation.