Dynamic import

[piscisaureus]

My attempt at fixing #2510.
The scope went a little overboard.
cc @ry

[piscisaureus]

The core point of the fix is here: https://github.com/denoland/deno/pull/2516/files#diff-7170d073ffb6b76573055a7aaba20d7fR568

[ry]

Does this compile for you? I'm getting type errors.

I kinda see the point of having this register() function to pass the &mut Isolate into the module code, but I don't understand what is being streamed.

[piscisaureus]

Eventually this should go. I added it to make porting over the tests easier.

[ry]

ref #1789

[ry]

Update: This is close to landing and still being worked on.

[bartlomieju]

Some remarks from me. I need a bit more time to grok modules::State though...

[bartlomieju]

/core/modules.rs became very hard to understand again, but we can surely update it down the road. It's awesome to finally have dynamic imports!

[ry]

On appveyor the unit tests are failing. No idea why.

Summary for <no permissions>
undefined
Summary for --allow-read
test result: OK. 34 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out (58.00ms)
Summary for --allow-net
test result: OK. 23 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out (5514.00ms)
Summary for --allow-read --allow-write
test result: OK. 47 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out (80.00ms)
Summary for --allow-write
test result: OK. 16 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out (20.00ms)
Summary for --allow-env
test result: OK. 4 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out (10.00ms)
Summary for --allow-run
test result: OK. 12 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out (254.00ms)
Summary for --allow-write --allow-run
test result: OK. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out (36.00ms)
Summary for --allow-read --allow-write --allow-run
test result: OK. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out (72.00ms)
Summary for --allow-hrtime
test result: OK. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out (-0.16ms)
Unit tests failed
FAIL

[piscisaureus]

https://github.com/denoland/deno/pull/2516/files#diff-e42bc8cc82b66eecdca76f5c6069e716?

[ry]

It's disabled https://github.com/denoland/deno/pull/2516/files#diff-06291984cb0c2f3e0fad6822ab277aec and not part of the unit tests.

I think we can land without error_014_catch_dynamic_import_error.js working yet.

[ry]

LGTM