Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve worker specifiers relative to main module of host. #2751

Merged
merged 3 commits into from
Aug 8, 2019
Merged

Resolve worker specifiers relative to main module of host. #2751

merged 3 commits into from
Aug 8, 2019

Conversation

afinch7
Copy link
Contributor

@afinch7 afinch7 commented Aug 8, 2019 •
edited
Loading

ref #2516 2745
I figure this is preferable, since it solves #2745 and when/if we add main module to import.meta this should be very predictable.

@afinch7 afinch7 closed this Aug 8, 2019
@afinch7 afinch7 reopened this Aug 8, 2019
ry
ry approved these changes Aug 8, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - no comments

@ry ry merged commit 56a82e7 into denoland:master Aug 8, 2019
@piscisaureus piscisaureus mentioned this pull request Aug 9, 2019
Merged
@afinch7 afinch7 mentioned this pull request Aug 9, 2019
Closed
@rheaditi rheaditi mentioned this pull request Jun 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afinch7 @ry