-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bundle installed script #5276
Conversation
d686a68
to
773651a
Compare
e092a49
to
9c0617a
Compare
I checked the the command works on a windows machine as well. @ry @bartlomieju PTAL |
Thanks @kt3k, can you fix the CI? I tried merging master but it seems it requires more changes. We'll try to land it for v1.1 |
a3b86fb
to
8ea9dab
Compare
@bartlomieju Thank you for the ping! I'm trying. |
done! |
I tested locally and it works fine. Unfortunately #4207 is still not resolved meaning that any script installed using TLA will break now. |
Only top level for await... TLA works fine. |
@kt3k can you rebase this? I would be interested in landing it now. |
@ry OK. I'll try today and tomorrow. |
1dec353
to
758596c
Compare
758596c
to
b73e7d5
Compare
Rebased! By the way I dropped the copying of tsconfig into bin directory because this bundles the script into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @kt3k and sorry it took so long to land!
This reverts commit 34e98fa.
This reverts the changes introduced by PR denoland#5276, which made `deno install «script»` automatically bundle the script's dependencies. It broke the `deno install` command for a large number of scripts. This reverts commit 34e98fa.
This reverts the changes introduced by PR denoland#5276, which made `deno install «script»` automatically bundle the script's dependencies. It broke the `deno install` command for a large number of scripts. This reverts commit 34e98fa. Closes: denoland#7492
This reverts the changes introduced by PR denoland#5276, which made `deno install «script»` automatically bundle the script's dependencies. It broke the `deno install` command for a large number of scripts. This reverts commit 34e98fa. Closes: denoland#7492
This reverts the changes introduced by PR denoland#5276, which made `deno install «script»` automatically bundle the script's dependencies. It broke the `deno install` command for a large number of scripts. This reverts commit 34e98fa. Closes: denoland#7492
This partially addresses #5069. This PR bundles installed script and saved it next to the executable shell/batch script.
The command works like the below:
I checked 2 examples working on mac and windows:
Closes #5069