Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat(install): bundle before installation (#5276)" #7522

Merged
merged 1 commit into from
Sep 16, 2020

Conversation

piscisaureus
Copy link
Member

This reverts the changes introduced by PR #5276, which made
deno install «script» automatically bundle the script's dependencies.
It broke the deno install command for a large number of scripts.

This reverts commit 34e98fa.

@bartlomieju
Copy link
Member

Closes #7492

piscisaureus added a commit to piscisaureus/deno that referenced this pull request Sep 16, 2020
This reverts the changes introduced by PR denoland#5276, which made
`deno install «script»` automatically bundle the script's dependencies.
It broke the `deno install` command for a large number of scripts.

This reverts commit 34e98fa.

Closes: denoland#7492
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This reverts the changes introduced by PR denoland#5276, which made
`deno install «script»` automatically bundle the script's dependencies.
It broke the `deno install` command for a large number of scripts.

This reverts commit 34e98fa.

Closes: denoland#7492
@piscisaureus piscisaureus merged commit 21f2e45 into denoland:master Sep 16, 2020
@piscisaureus piscisaureus deleted the revert-5276 branch September 16, 2020 17:10
vitormmatos pushed a commit to vitormmatos/deno that referenced this pull request Sep 21, 2020
This reverts the changes introduced by PR denoland#5276, which made
`deno install «script»` automatically bundle the script's dependencies.
It broke the `deno install` command for a large number of scripts.

This reverts commit 34e98fa.

Closes: denoland#7492
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants