Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(std): Fix FileHandler test with mode 'x' on non-English systems #5757

Merged
merged 2 commits into from
May 28, 2020
Merged

fix(std): Fix FileHandler test with mode 'x' on non-English systems #5757

merged 2 commits into from
May 28, 2020

Conversation

littletof
Copy link
Contributor

Fixes: #5756

@CLAassistant
Copy link

CLAassistant commented May 22, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@littletof littletof mentioned this pull request May 22, 2020
Closed
@littletof littletof changed the title fix(std): Fix FileHandler test with mode 'x' on non-English systems WIP: fix(std): Fix FileHandler test with mode 'x' on non-English systems May 22, 2020
@littletof littletof changed the title WIP: fix(std): Fix FileHandler test with mode 'x' on non-English systems fix(std): Fix FileHandler test with mode 'x' on non-English systems May 22, 2020
@littletof
Copy link
Contributor Author

littletof commented May 22, 2020 •
edited
Loading

I'm having some problems running the tools/format.py, so I couldn't find out why the linter fails yet.
Related: #5017

bartlomieju
bartlomieju approved these changes May 28, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @littletof

@bartlomieju bartlomieju merged commit c9f7558 into denoland:master May 28, 2020
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Jun 5, 2020
@littletof @bartlomieju
fix(std): Fix FileHandler test with mode 'x' on non-English systems (d…
f74182d 
…enoland#5757)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@littletof
fix(std): Fix FileHandler test with mode 'x' on non-English systems (d…
58098a2 
…enoland/deno#5757)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@littletof
fix: Fix FileHandler test with mode 'x' on non-English systems (denol…
b3701ca 
…and/deno#5757)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@littletof @caspervonb
fix: Fix FileHandler test with mode 'x' on non-English systems (denol…
1c10482 
…and/deno#5757)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@littletof @caspervonb
fix: Fix FileHandler test with mode 'x' on non-English systems (denol…
cc30b4a 
…and/deno#5757)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@littletof @caspervonb
fix: Fix FileHandler test with mode 'x' on non-English systems (denol…
a59c2ce 
…and/deno#5757)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@littletof @caspervonb
fix: Fix FileHandler test with mode 'x' on non-English systems (denol…
adbd6eb 
…and/deno#5757)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@littletof @caspervonb
fix: Fix FileHandler test with mode 'x' on non-English systems (denol…
b7a5d3c 
…and/deno#5757)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@littletof @denobot
fix: Fix FileHandler test with mode 'x' on non-English systems (denol…
2aa4671 
…and/deno#5757)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@littletof @denobot
fix: Fix FileHandler test with mode 'x' on non-English systems (denol…
4513486 
…and/deno#5757)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FileHandler test with mode 'x' fails non-English systems
3 participants
@littletof @CLAassistant @bartlomieju