Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(std): Fix FileHandler test with mode 'x' on non-English systems #5757

Merged
merged 2 commits into from
May 28, 2020
Merged

fix(std): Fix FileHandler test with mode 'x' on non-English systems #5757

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e097c7
fix: Fix FileHandler test with mode x on non-English systems
littletof May 22, 2020
ada795e
Fix lint error
littletof May 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions std/log/handlers_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,18 +115,14 @@ test({
test({
name: "FileHandler with mode 'x' will throw if log file already exists",
async fn() {
await assertThrowsAsync(
async () => {
Deno.writeFileSync(LOG_FILE, new TextEncoder().encode("hello world"));
const fileHandler = new FileHandler("WARNING", {
filename: LOG_FILE,
mode: "x",
});
await fileHandler.setup();
},
Deno.errors.AlreadyExists,
"ile exists"
);
await assertThrowsAsync(async () => {
Deno.writeFileSync(LOG_FILE, new TextEncoder().encode("hello world"));
const fileHandler = new FileHandler("WARNING", {
filename: LOG_FILE,
mode: "x",
});
await fileHandler.setup();
}, Deno.errors.AlreadyExists);
Deno.removeSync(LOG_FILE);
},
});
Expand Down