refactor(repl): use an inspector session #7763

caspervonb · 2020-09-30T05:57:29Z

This ports the REPL over to Rust and makes use of an inspector session to run a REPL on top of any isolate which lets make full use of rustylines various things like validators and completors without having to introduce a bunch of hard to test internal ops and glue code.

An accidental but good side effect of this is that the multiple line input we previously had is now an editable multi-line input prompt that is correctly stored in the history as a single entry.

We'll also be able to enable top level await via replMode in Runtime.evaluate (inspector protocol).

cli/repl.rs

cli/tests/integration_tests.rs

cli/repl.rs

caspervonb · 2020-10-01T03:07:16Z

cli/tests/integration_tests.rs

@@ -1157,6 +1157,7 @@ fn repl_test_function() {
 }

 #[test]
+#[ignore]


Temporarily ignored, editing (e.g multiline) only works with a tty.

bartlomieju

Awesome work @caspervonb just a few minor nitpicks, but other than that I think it's landable.

bartlomieju · 2020-10-01T08:28:16Z

cli/repl.rs

-pub struct Repl {
-  editor: Editor<()>,
-  history_file: PathBuf,
+#[derive(Completer, Helper, Highlighter, Hinter)]


Does using derive here actually provide completions/hints/highlights? Or is it just to have default impls?

Just to have default no-op implementations because the Helper trait requires them all to be implemented.

cli/repl.rs

bartlomieju · 2020-10-01T08:32:17Z

cli/repl.rs

+        let is_closing = session
+          .post_message(
+            "Runtime.evaluate".to_string(),
+            Some(json!({
+              "expression": "(globalThis.closed)",
+              "contextId": context_id,
+            })),
+          )
+          .await?
+          .get("result")
+          .unwrap()
+          .get("value")


bartlomieju · 2020-10-01T08:33:10Z

cli/rt/99_main.js

-    if (repl) {
-      replLoop();
-    }


Nice to see this go

bartlomieju · 2020-10-01T08:42:35Z

cli/repl.rs

+              "contextId": context_id,
+              // TODO(caspervonb) set repl mode to true to enable const redeclarations and top
+              // level await
+              "replMode": false,


It'd be great if we could switch this on before Friday's release

I'll flip it and add tests as soon as this lands.

ry · 2020-10-01T19:48:17Z

This used to work, but appears to be broken in this branch:

~/src/deno> cargo run
   Compiling deno v1.4.2 (/Users/rld/src/deno/cli)
    Finished dev [unoptimized + debuginfo] target(s) in 1m 11s
     Running `target/debug/deno`
Deno 1.4.2
exit using ctrl+d or close()
> function add(a, b) {
return a + b;
}
[Function: add]
> add(1, 2)
Uncaught ReferenceError: add is not defined
    at <anonymous>:2:1
>

caspervonb · 2020-10-01T20:04:16Z

This used to work, but appears to be broken in this branch:

Oops, yeah bit too eager on the wrapping, need to wind it back to just starts_with("{" like #7591 did.

caspervonb · 2020-10-01T21:21:58Z

Toned it down a bit to match #7591 exactly.

bartlomieju

LGTM, massive work @caspervonb

This reverts commit 4c779b5.

This ports the REPL over to Rust and makes use of an inspector session to run a REPL on top of any isolate which lets make full use of rustylines various things like validators and completors without having to introduce a bunch of hard to test internal ops and glue code. An accidental but good side effect of this is that the multiple line input we previously had is now an editable multi-line input prompt that is correctly stored in the history as a single entry.

refactor(repl): use an inspector session

043ee12

caspervonb force-pushed the refactor-repl-use-an-inspector-session branch from 11b8f10 to 043ee12 Compare September 30, 2020 05:59

Lint

5c0ed58

caspervonb commented Sep 30, 2020

View reviewed changes

cli/repl.rs Outdated Show resolved Hide resolved

caspervonb commented Sep 30, 2020

View reviewed changes

cli/repl.rs Outdated Show resolved Hide resolved

caspervonb commented Sep 30, 2020

View reviewed changes

cli/repl.rs Outdated Show resolved Hide resolved

caspervonb added 15 commits September 30, 2020 06:23

Turn repl mode comment into a TODO comment

f41db9c

Add real multi-line editing with a bracket validator

b882005

Remove repl flag from op start

203dd77

Lint

a286e29

Format

5335bc7

Remove debug output on readline errors

dbae724

Fix flags tests

f2750a2

Save and load history file

7568a7e

Ensure history file always exists

06293a2

Allow history load to fail

4db45f5

Print errors to stderr

98ccecd

Support _ and _error

36c659d

Break on globalThis.closed

0302a23

Format

0e7bf5a

Move close check to after eval to avoid printing the result of close()

ad40189

caspervonb commented Sep 30, 2020

View reviewed changes

cli/tests/integration_tests.rs Show resolved Hide resolved

caspervonb added 5 commits September 30, 2020 22:40

Wrap and retry input

48e749b

Ignore multiline test

a73b9b7

Evaluate in strict mode

64d6e2a

Disable validator for a minute

90f4388

Fixup

922f7bc

caspervonb commented Oct 1, 2020

View reviewed changes

cli/repl.rs Outdated Show resolved Hide resolved

caspervonb added 2 commits October 1, 2020 01:47

Spawn blocking

8e6127d

Re-enable validator

af1a4de

Fixup

fe38ac5

caspervonb commented Oct 1, 2020

View reviewed changes

caspervonb marked this pull request as ready for review October 1, 2020 03:09

caspervonb mentioned this pull request Oct 1, 2020

feat(cli/repl): automatically indent multi-line inputs #7597

Closed

bartlomieju reviewed Oct 1, 2020

View reviewed changes

Explain retry mechanism

d43e17c

caspervonb added 3 commits October 1, 2020 20:12

Only wrap on things that look like it may be an object literal

e4d374b

Lint

2559fa3

More lint

3e7c724

Minor comment on helper struct

6548e21

bartlomieju approved these changes Oct 1, 2020

View reviewed changes

bartlomieju merged commit 4c779b5 into denoland:master Oct 1, 2020

This was referenced Oct 2, 2020

fix(cli/repl): enable await and let re-declarations #7784

Merged

Dynamic import regression in the read-eval-print-loop #7786

Closed

ry added a commit to ry/deno that referenced this pull request Oct 2, 2020

Revert "refactor(repl): use an inspector session (denoland#7763)"

3dc0e45

This reverts commit 4c779b5.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(repl): use an inspector session #7763

refactor(repl): use an inspector session #7763

caspervonb commented Sep 30, 2020 •

edited

Loading

caspervonb Oct 1, 2020 •

edited

Loading

bartlomieju left a comment

bartlomieju Oct 1, 2020

caspervonb Oct 1, 2020

bartlomieju Oct 1, 2020

bartlomieju Oct 1, 2020

bartlomieju Oct 1, 2020

caspervonb Oct 1, 2020

ry commented Oct 1, 2020 •

edited

Loading

caspervonb commented Oct 1, 2020

caspervonb commented Oct 1, 2020

bartlomieju left a comment

refactor(repl): use an inspector session #7763

refactor(repl): use an inspector session #7763

Conversation

caspervonb commented Sep 30, 2020 • edited Loading

caspervonb Oct 1, 2020 • edited Loading

Choose a reason for hiding this comment

bartlomieju left a comment

Choose a reason for hiding this comment

bartlomieju Oct 1, 2020

Choose a reason for hiding this comment

caspervonb Oct 1, 2020

Choose a reason for hiding this comment

bartlomieju Oct 1, 2020

Choose a reason for hiding this comment

bartlomieju Oct 1, 2020

Choose a reason for hiding this comment

bartlomieju Oct 1, 2020

Choose a reason for hiding this comment

caspervonb Oct 1, 2020

Choose a reason for hiding this comment

ry commented Oct 1, 2020 • edited Loading

caspervonb commented Oct 1, 2020

caspervonb commented Oct 1, 2020

bartlomieju left a comment

Choose a reason for hiding this comment

caspervonb commented Sep 30, 2020 •

edited

Loading

caspervonb Oct 1, 2020 •

edited

Loading

ry commented Oct 1, 2020 •

edited

Loading