Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli/repl): enable await and let re-declarations #7784

Merged
merged 1 commit into from
Oct 2, 2020
Merged

fix(cli/repl): enable await and let re-declarations #7784

merged 1 commit into from
Oct 2, 2020

Conversation

caspervonb
Copy link
Contributor

@caspervonb caspervonb commented Oct 2, 2020 •
edited
Loading

This enables replMode during evaluations which allows for top level await and let re-declarations.

Fixes #3700 #3029

@caspervonb
feat(cli/repl): enable await and let re-declarations
41914cf 
This enables `replMode` during evaluations which allows for top level
await and let re-declarations.
@caspervonb
Copy link
Contributor Author

caspervonb commented Oct 2, 2020 •
edited
Loading

Not sure if we should consider #1285 resolved with this as await import works now

Looks like we have a small regression in import resolution introduced by #7763.

@nayeemrmn
Copy link
Collaborator

It seems like relative imports don't work with this.
image
Currently dynamic imports are resolved relative to a dummy file in the cwd.

@bartlomieju
Copy link
Member

@caspervonb maybe mark as fix(cli/repl) 😅 ?

@caspervonb caspervonb changed the title feat(cli/repl): enable await and let re-declarations fix(cli/repl): enable await and let re-declarations Oct 2, 2020
bartlomieju
bartlomieju approved these changes Oct 2, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 awesome update @caspervonb

@bartlomieju
Copy link
Member

CC @solson I recall you were waiting on TLA in REPL

@bartlomieju bartlomieju merged commit 5cd29b3 into denoland:master Oct 2, 2020
This was referenced Oct 2, 2020
Closed
Closed
@solson solson mentioned this pull request Oct 2, 2020
Closed
ry added a commit to ry/deno that referenced this pull request Oct 2, 2020
@ry
Revert "feat(cli/repl): enable await and let re-declarations (denolan…
17a6f7e 
…d#7784)"

This reverts commit 5cd29b3.
JavascriptMick pushed a commit to JavascriptMick/deno that referenced this pull request Oct 5, 2020
@caspervonb @JavascriptMick
feat(cli/repl): enable await and let re-declarations (denoland#7784)
2132b3d 
This enables `replMode` during evaluations which allows for top level
await and let re-declarations.
Soremwar pushed a commit to Soremwar/deno that referenced this pull request Oct 6, 2020
@caspervonb @Soremwar
feat(cli/repl): enable await and let re-declarations (denoland#7784)
5d546e7 
This enables `replMode` during evaluations which allows for top level
await and let re-declarations.
@nayeemrmn nayeemrmn mentioned this pull request Feb 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

await should work in REPL
3 participants
@caspervonb @nayeemrmn @bartlomieju