-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable Deno APIs by default in Workers #8178
Conversation
This is a breaking change because it would change the default permissions of |
945df45
to
be7d6ce
Compare
be7d6ce
to
90bb5be
Compare
I'm in favor of this change, I especially like how it simplifies |
90bb5be
to
ddde4b3
Compare
@bartlomieju Please review. |
@nayeemrmn This is on hold because we can't land until 2.0. (Security related breaking change) |
Hmm... was this ever an intended security mechanism? It was always arbitrary that workers inherited net permissions with The only cases where this provides new-found e.g. read permissions are where the runtime was granted |
Intended or not, it is in stable, so we have to take this into consideration before merging. People might be using workers for sandboxing. |
@nayeemrmn I'm in favor of landing this PR, but I think Luca has a point. Let's discuss further on Discord |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
I'm closing this PR because it's stale and there's a bunch of merge conflicts. But we're going to discuss this issue soon and try to come to some consensus on proceeding. To be continued.... |
@nayeemrmn can you open a new PR with this change? It's still highly desired and now that we're eyeballing 2.0 it'd be great to have it. |
Closes #8174.