fix(fast_check): better support for auto accessors #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** Some comment */ declare public_accessor: string; | ||
| declare private private_accessor: any; | ||
| declare static static_accessor: number; | ||
| declare private static private_static: any; |
There was a problem hiding this comment.
Wondering where the any is coming from. The original value is a '' literal which could be inferred as string here.
There was a problem hiding this comment.
It's a private property, so I made them all any so that we don't have to do analysis on them or surface diagnostics.
marvinhagemeister
approved these changes
Mar 12, 2024
dsherret
added a commit
to denoland/deno
that referenced
this pull request
Mar 12, 2024
…as exprs (#22849) Several fixes in deno_graph: * denoland/deno_graph#411 * denoland/deno_graph#413 * denoland/deno_graph#414 * denoland/deno_graph#415 * denoland/deno_graph#416 * denoland/deno_graph#417 Also created https://github.com/denoland/publish_smoke_tests to help prevent regressions in the future. Closes #22829 Closes #22819 Closes #22802
nathanwhit
pushed a commit
to denoland/deno
that referenced
this pull request
Mar 14, 2024
…as exprs (#22849) Several fixes in deno_graph: * denoland/deno_graph#411 * denoland/deno_graph#413 * denoland/deno_graph#414 * denoland/deno_graph#415 * denoland/deno_graph#416 * denoland/deno_graph#417 Also created https://github.com/denoland/publish_smoke_tests to help prevent regressions in the future. Closes #22829 Closes #22819 Closes #22802
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.