Add no-undef

[kdy1]

I confused no-global-assign with no-undef.
I thought no-global was about prohibiting assignment to global variables.
So I implemented it, but the name of such pass was no-undef.

[bartlomieju]

Looking good, I'll check that it works as expected on deno codebase before landing.

[bartlomieju]

Some false positives:

    await new Promise((resolve: () => void, _) => {
      setTimeout(resolve, 100);
    });

// 
(no-undef) resolve is not defined
      setTimeout(resolve, 100);
                 ^^^^^^^
    at /Users/biwanczuk/dev/deno/cli/tests/unit/net_test.ts:331:17

const checkErr = (e: Error): void => {
      if (e.message === "Listener has been closed") {
        assertEquals(acceptErrCount, 1);
      } else if (e.message === "Another accept task is ongoing") {
        acceptErrCount++;
      } else {
        throw new Error("Unexpected error message");
      }
    };

// 
(no-undef) e is not defined
    const checkErr = (e: Error): void => {
                      ^^^^^^^^
    at /Users/biwanczuk/dev/deno/cli/tests/unit/net_test.ts:136:22

(no-undef) e is not defined
      if (e.message === "Listener has been closed") {
          ^
    at /Users/biwanczuk/dev/deno/cli/tests/unit/net_test.ts:137:10

Other builtins that should be listed:

• Symbol
• TextEncoder
• TextDecoder
• undefined
• Deno
• Uint8Array
• Error

Edit: Actually there's way more globals to list (https://www.npmjs.com/package/globals) - @kdy1 I'll update that list later, when you're done with the logic.

[kdy1]

False positives were caused by the bug in ts_resolver, which is now fixed.

[bartlomieju]

@kdy1 some false positives I found

Class constructor param:

(no-undef) options is not defined
  constructor(options: ContextOptions) {
              ^^^^^^^^^^^^^^^^^^^^^^^
    at /Users/biwanczuk/dev/deno/std/wasi/snapshot_preview1.ts:305:14

(no-undef) options is not defined
    this.args = options.args ? options.args : [];
                ^^^^^^^
    at /Users/biwanczuk/dev/deno/std/wasi/snapshot_preview1.ts:306:16

Case using enum variant:

(no-undef) OpCode is not defined
        case OpCode.Close: {
             ^^^^^^
    at /Users/biwanczuk/dev/deno/std/ws/mod.ts:262:13

Class name inside class method:

(no-undef) Buffer is not defined
  value: Buffer,
         ^^^^^^
    at /Users/biwanczuk/dev/deno/std/node/buffer.ts:592:9

Catch binding:

(no-undef) err is not defined
  } catch (err) {
           ^^^
    at /Users/biwanczuk/dev/deno/std/ws/example_client.ts:56:11

[bartlomieju]

@kdy1 the only missing globals I found are Headers and TransformStream

[kdy1]

Got it, thanks!

[kdy1]

Published a new version of swc_ecma_visit, swc_ecma_transforms, swc_ecmascript.

Patch of swc_ecma_visit is about reducing compile time while debugging, and patch of swc_ecma_transforms is about fixing resolver.

I copied some failing test cases from deno std_lint and verified locally that new version of resolver make the lint work properly.

[bartlomieju]

@kdy1 thanks, I will start upgrades soon

[bartlomieju]

LGTM 🚀