Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-redeclare #307

Merged
merged 19 commits into from
Sep 12, 2020
Merged

Add no-redeclare #307

merged 19 commits into from
Sep 12, 2020

Conversation

kdy1
Copy link
Contributor

@kdy1 kdy1 commented Sep 9, 2020

Resolver (aka span hygiene) makes many things easy :)

Some parts of the lint is not implemented because there are no list of globals yet. (Related: #304)


Note: Parameter issues seems like a bug of swc.

@kdy1 kdy1 marked this pull request as ready for review September 12, 2020 11:36
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bartlomieju bartlomieju merged commit 115f523 into denoland:master Sep 12, 2020
@kdy1 kdy1 deleted the no-redeclare branch September 12, 2020 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants