-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dnt exiting normally even though tests fail #86
Labels
bug
Something isn't working
Comments
I'm also running into this the test fails on node14 as expected but dnt still finishes with exitCode 0
This seems to be a problem with the generated |
I submitted a fix #89 |
Related: denoland/node_shims#80 in shim-deno. It's fixed there, we just need to get an npm release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm setting up some Github workflows that include
dnt
, and am testing against Node v12, v14, and v16.I expect my build script to fail with v12 and v14 at this point, but v14 is succeeding even though a problem is encountered during tests: https://github.com/earthstar-project/stone-soup/runs/4738270806?check_suite_focus=true#step:5:135
The text was updated successfully, but these errors were encountered: