Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shim EventTarget to support Node 14 #80

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Shim EventTarget to support Node 14 #80

merged 1 commit into from
Jan 7, 2022

Conversation

wojpawlik
Copy link
Contributor

Trying to make tests pass on Node 14 (#77) proved difficult. This non-breaking change makes them at least run.

dsherret
dsherret approved these changes Jan 7, 2022
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @wojpawlik!

@dsherret dsherret merged commit cfdbddc into denoland:main Jan 7, 2022
@cinnamon-bun cinnamon-bun mentioned this pull request Feb 5, 2022
Closed
@cinnamon-bun
Copy link

cinnamon-bun commented Feb 5, 2022 •
edited
Loading

Hi friends,
Any chance we could get a new npm release containing this fix? It's blocking us from using node 14 (via dnt).

Thanks 💜

@cinnamon-bun cinnamon-bun mentioned this pull request Feb 5, 2022
Closed
@dsherret
Copy link
Member

dsherret commented Feb 5, 2022

@cinnamon-bun released and if you use dnt 0.17 it will use it automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wojpawlik @cinnamon-bun @dsherret