Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: actually fail when require(umdPath) throws #89

Merged
merged 2 commits into from
Jan 8, 2022
Merged

fix: actually fail when require(umdPath) throws #89

merged 2 commits into from
Jan 8, 2022

Conversation

chronark
Copy link
Contributor

@chronark chronark commented Jan 8, 2022 •
edited
Loading

The generated test script did not actually fail when require(umdPath) throws.
Wrapping it in a try catch and explicitly calling process.exit(1) seems to do the trick.

This resolves #86

@CLAassistant
Copy link

CLAassistant commented Jan 8, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@chronark chronark mentioned this pull request Jan 8, 2022
Closed
@dsherret dsherret merged commit e790b15 into denoland:main Jan 8, 2022
@dsherret
Copy link
Member

dsherret commented Jan 8, 2022

Thanks @chronark!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dnt exiting normally even though tests fail
3 participants
@chronark @CLAassistant @dsherret