-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server): dev safety checks #1489
Conversation
add58ea
to
cd42d46
Compare
9291352
to
d71919c
Compare
Thanks for finishing this up. Looks pretty good, but I wonder if we want to specifically create a union type for all the categories and then reference them as something like this: return [{
category: DevChecks.ModuleExport,
message: `Your ${moduleName} file does not have a default export.`,
fileLink: moduleName,
}]; instead of return [{
category: "Module Export",
message: `Your ${moduleName} file does not have a default export.`,
fileLink: moduleName,
}]; Additionally, what about implementing the check in #1414? And taking the tests as well. Then I can just close that one, and a maintainer can close #539. And then you can resolve three issues at once (the two you mention, plus 475 which I was going to resolve). |
@deer thanks for the suggestion. will incorporate everything you mentioned! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for adding these 🎉
Apologies for the churn. I merged the PR too quickly and it's currently blocking me on feature work, so I've reverted it in #1567. So far I encountered that the handlers rule doesn't account for them being an array. The output is a bit messy when there are multiple errors. Maybe some visual hierarchy via colors can help? Most rules don't print the file name where the error happened which makes it difficult to track down where the error is coming from. The |
closes #1416
closes #1524
as discussed in the aforementioned issue, @deer was so kind to let me finish this one off.
as expected it gave me quite some nice understanding of
fresh
's internals.this pr introduces the following check when being in
dev
mode:pascal case or kebab case islands (island name)(this one became obsolete w/ 1.3)the functionality can be tested by navigating into
tests/fixture_dev_checks/
and runningdeno task start