-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server): add safety checks during dev #1568
base: main
Are you sure you want to change the base?
Conversation
You should go into each fixture and start up the dev server to confirm this isn't causing issues. Perhaps we could even add a test to assert that all the fixtures adhere to these checks. |
will do! i'd also incorporate the feedback and remarks from the first pr. |
I see some changes of Some of the names in the error messages don't seem quite right:
I would expect:
|
as always, thank you for the feedback!
sorry about that!
you're absolutely right! |
improved the warnings output as suggested. |
Seems like this should eventually cover #1678 (comment) as well. |
found a way to naively check the existence plugins in the current |
#1950 (comment) is another example of a good check to add. |
this is the second attempt to land #1489, as the initial version has been reverted due to unwanted side effects.
closes #475.
closes #1558.
closes #1678.
supersedes #539.
supersedes #1414.
this pr introduces the following check when being in
dev
mode:pascal case or kebab case islands (island name)(this one became obsolete w/ 1.3)the functionality can be tested by changing the
fixture
task indeno.json
to:this time, the pr also contains unit tests for each individual check to (hopefully 🤞 ) prevent further mishaps.