Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

todo: use ULIDs for notification functionality #473

Closed
Tracked by #476
iuioiua opened this issue Sep 1, 2023 · 0 comments · Fixed by #483
Closed
Tracked by #476

todo: use ULIDs for notification functionality #473

iuioiua opened this issue Sep 1, 2023 · 0 comments · Fixed by #483
Assignees
@iuioiua
Labels
v1

Comments

@iuioiua
Copy link
Contributor

iuioiua commented Sep 1, 2023 •
edited
Loading

See #476
@iuioiua iuioiua added the v1 label Sep 1, 2023
@iuioiua iuioiua self-assigned this Sep 1, 2023
This was referenced Sep 1, 2023
Closed
Merged
iuioiua added a commit that referenced this issue Sep 4, 2023
@iuioiua
refactor: use ULID for notifications functionality (#483)
a21ebc7 
Changes:
1. Notifications use ULIDs for their IDs.
2. Removes the `notifications` index from KV, as it seems unnecessary.
3. Removed the `createdAt` property from notifications.
4. Removes `newNotificationProps()`, as it now seems unnecessary.

Closes #473
Towards #470
CC @lino-levan (this might be a good reference to learn more about
ULIDs)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iuioiua iuioiua

Labels
v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: use ULID for notifications functionality denoland/saaskit
1 participant
@iuioiua