Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

todo: rename and restructure /tools folder #470

Closed
2 tasks
iuioiua opened this issue Sep 1, 2023 · 3 comments · Fixed by #503
Closed
2 tasks

todo: rename and restructure /tools folder #470

iuioiua opened this issue Sep 1, 2023 · 3 comments · Fixed by #503
Assignees
Labels
good first issue Good for newcomers v1

Comments

@iuioiua
Copy link
Contributor

iuioiua commented Sep 1, 2023

Suggestion:

  • Rename /tools to /tasks
  • Have each filename match up to the task name. E.g. db:reset task for /tasks/db_reset.ts.
@iuioiua iuioiua added good first issue Good for newcomers v1 labels Sep 1, 2023
@rj2704
Copy link
Contributor

rj2704 commented Sep 1, 2023

Hi, I want to work on this issue. Can you please elaborate on the second point that we need to fix?

@iuioiua
Copy link
Contributor Author

iuioiua commented Sep 1, 2023

Great! Thank you. The deno.json file has a number of tasks. Each task correlates with one of the scripts currently in /tools. However, their names do not match their respective file and function names, as given in my example. The task, file and function names matching makes their purposes clearer.

@iuioiua
Copy link
Contributor Author

iuioiua commented Sep 3, 2023

Hi, @rj2704. Actually, no need to have a main function since each file is a script. Check out #483. It gives an example of what I'm after by having a db:migrate task and the tasks/db_migrate.ts script.

iuioiua added a commit that referenced this issue Sep 4, 2023
Changes:
1. Notifications use ULIDs for their IDs.
2. Removes the `notifications` index from KV, as it seems unnecessary.
3. Removed the `createdAt` property from notifications.
4. Removes `newNotificationProps()`, as it now seems unnecessary.

Closes #473
Towards #470
CC @lino-levan (this might be a good reference to learn more about
ULIDs)
iuioiua pushed a commit that referenced this issue Sep 5, 2023
Description

This PR fixes #470 

Notes for Reviewers
rename and restructure /tools folder

---------

Signed-off-by: Jigar Rathod <jigarrathod2704@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers v1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants