Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rename and restructure /tools folder #503

Merged
merged 2 commits into from
Sep 5, 2023
Merged

refactor: rename and restructure /tools folder #503

merged 2 commits into from
Sep 5, 2023

Conversation

rj2704
Copy link
Contributor

@rj2704 rj2704 commented Sep 5, 2023

Description

This PR fixes #470

Notes for Reviewers
rename and restructure /tools folder

@rj2704
rename and restructure /tools folder
7a3fad8 
Signed-off-by: Jigar Rathod <jigarrathod2704@gmail.com>
iuioiua
iuioiua suggested changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting, @rj2704! Few suggested changes.

tasks/reset_kv.ts Outdated Show resolved Hide resolved
@rj2704
Modified deno.json and Renamed script names
ca20cef 
Signed-off-by: Jigar Rathod <jigarrathod2704@gmail.com>
@iuioiua iuioiua changed the title rename and restructure /tools folder refactor: restructure tasks Sep 5, 2023
@iuioiua iuioiua changed the title refactor: restructure tasks refactor: rename and restructure /tools folder Sep 5, 2023
iuioiua
iuioiua approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! LGTM! Thank you for your contribution, @rj2704.

@iuioiua iuioiua merged commit 93f7337 into denoland:main Sep 5, 2023
@rj2704
Copy link
Contributor Author

rj2704 commented Sep 5, 2023

Excellent! LGTM! Thank you for your contribution, @rj2704.

Thanks, @iuioiua looking forward to making more contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuioiua iuioiua iuioiua approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

todo: rename and restructure /tools folder
2 participants
@rj2704 @iuioiua