Add include and exclude #196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update from upstream
update from upstream
update from upstream
|
@lucacasonato @bartlomieju @axetroy Ready for review |
Update from upstream
|
@CGQAQ The LSP crashes for me when I try to use this in a mixed Node and Deno project (denoland/doc_website) with this {
"deno.enable": true,
"deno.unstable": true,
"deno.include": ["api/docs.ts"]
}Extension host error:My ts server log |
|
@lucacasonato that's weird the only script I can see is |
|
Let me clarify: this did not work before either, but I thought that only including certain files would solve this issue. It seems it does not. That either means that this PR does not filter in all places it should, or more likely that we have another bug in the LSP that causes it to crash when its used on a folder that contains a Node project. |
Is the project opensource so I can test myself? the LSP is always running, I did not close the LSP, just add a flag that makes LSP features run conditionally |
|
Ok, I'll debug it |
|
|
|
So it seems the crash is happening outside of the extension in the tsserver? I guess we can land this with this bug (it is not new) and then I will do more debugging to see what causes this. |
Sure, we can land this, I think it's |
|
@lucacasonato Found it |
|
@lucacasonato @axetroy microsoft/vscode#106346, it seems configurePlugin is disbled above typescript 4.0.1 |
|
@lucacasonato The bug is likely fixed by vscode team in microsoft/vscode#106346, so we just need to wait vscode update |
|
I'll review this PR today still so we can land it. |
|
@CGQAQ It doesn't work for me even in a Deno only project:
|
This comment has been minimized.
This comment has been minimized.
CGQAQ
commented
Sep 10, 2020
@CGQAQ Because you did not change the
The conclusion is: not easy to do The key is eg. vscode_deno/typescript-deno-plugin/src/plugin.ts Lines 154 to 175 in d61b8b1 This proxy how Typescript gets the configuration, but frankly, we don’t know its context It's hard to tell whether I should apply Deno's configuration and also this vscode_deno/typescript-deno-plugin/src/plugin.ts Lines 177 to 196 in d61b8b1 In the final analysis, the functions provided by Typescript plugins are not enough to do these things So far, I don’t have a good solution, if so, please let me know |
|
@axetroy I'm finding a way to unconfig the It's very hard to debug the plugin, I installed this, but still cant hit breakpoint, if you know what to do, please let me know @axetroy |
I also found this and tried to let breakpoint work, unluckily still doesn't work, struggling now @axetroy |
|
Where is the Deno namespace come from? vscode_deno/typescript-deno-plugin/src/plugin.ts Lines 185 to 189 in d61b8b1 dts loaded, but completion didn't work tsserver.log |
|
This method gives new value but tsserver don't use it, I deleted the code in green circle, it works |
|
didn't work either |
…o into add_include_and_exclude
|
Still don't get any response yet, if anyone knows how to solve this, please let me know |
|
Not possible for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add include and exclude config
Part of roadmap 2 (#194)
Closes #75, Closes #50, Closes #39, Closes #60, Closes #87