Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enable disable command #197

Closed
wants to merge 11 commits into from

Conversation

CGQAQ
Copy link
Contributor

@CGQAQ CGQAQ commented Sep 9, 2020

Depends on #196, Please review it first

Show enable command when lsp is disabled, disable command when lsp is enabled

pr3

pr

Part of roadmap 2 (#194)

Closes #170

@CGQAQ
Copy link
Contributor Author

CGQAQ commented Sep 9, 2020

@bartlomieju @axetroy @lucacasonato Ready for review

@David-Else
Copy link

I remember this addition was debated before in the old extension and removed. I like the idea, but my only reservation is that now there are more options, logically they should be togglable as well? Perhaps instead Init Deno project creates and opens:

// .vscode/settings.json
{
  "deno.enable": true,
  "deno.unstable": true,
  "deno.lint": true,
}

This could be a nice time-saver? It would force people to make decisions on these options right away, and educate them that they exist.

@CGQAQ
Copy link
Contributor Author

CGQAQ commented Sep 11, 2020

I think to add every config to command is not a good idea

@axetroy
Copy link
Contributor

axetroy commented Sep 11, 2020

I think to add every config to command is not a good idea

as I said. #170 (comment)

Consider adding a deno.init or deno.setup command for configuration.

@CGQAQ
Copy link
Contributor Author

CGQAQ commented Sep 29, 2020

Don't need anymore

@CGQAQ CGQAQ closed this Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[regression] deno enable/disable command palette entries removed
3 participants