tsserver code actions implementation #3418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@w0rp please review this. Maybe I should change naming or I have missed something. |
There might be situations when the error is reported by multiple sources at the same location (e.g. eslint and tsserver). In that case first source might be missing `code`.
This is done to accommodate the fact that in the future there will be more capabilities: refactorings from tsserver and LSP Code Actions.
We will lose one testing layer but I think it is acceptable in this situation.
It seems edits assumes that lines includes end-of-line symbol. Meanwhile Vim's readfile command omits new lines (\n) and carriage return (\r) symbols if there are any.
Previously code was applied from top-to-bottom that required extra parameters to track progress and there was bug. I have changed code to bottom-to-top approach as that does not require those extra parameters and solved the bug.
|
Closed because there is pull request now that implements code actions fully: #3437 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is implementation for code fix and applicable refactors support for tsserver.
Related issue #1466