Support for LSP/tsserver Code Actions #3437

daliusd · 2020-11-14T08:42:45Z

Related issue #1466

Relates issue #1466

There might be situations when the error is reported by multiple sources at the same location (e.g. eslint and tsserver). In that case first source might be missing `code`.

This is done to accommodate the fact that in the future there will be more capabilities: refactorings from tsserver and LSP Code Actions.

We will lose one testing layer but I think it is acceptable in this situation.

It seems edits assumes that lines includes end-of-line symbol. Meanwhile Vim's readfile command omits new lines (\n) and carriage return (\r) symbols if there are any.

Previously code was applied from top-to-bottom that required extra parameters to track progress and there was bug. I have changed code to bottom-to-top approach as that does not require those extra parameters and solved the bug.

E.g.: jedi-language-server returns null in some cases.

Tested with typescript-language-server and it is working.

w0rp

This is great. Let's just do it.

I'll modify the things I've mentioned here.

w0rp · 2020-11-14T09:59:10Z

autoload/ale/code_action.vim

@@ -33,35 +33,35 @@ endfunction

 function! s:ChangeCmp(left, right) abort
    if a:left.start.line < a:right.start.line
-        return -1
+        return 1
    endif


It makes more sense for the cmp function to sort forwards. Apply reverse() to reverse the List below.

Sounds good.

w0rp · 2020-11-14T10:03:04Z

doc/ale.txt

+
+  Code Actions support for `tsserver`.
+
+  There are two different kind of actions supported for `tsserver`. If run in


There are some typos here to fix.

w0rp · 2020-11-14T10:03:29Z

doc/ale.txt

+  If there are multiple code fixes available use will be shown input to choose
+  one. In visual mode `tsserver` will be queries for applicable refactors
+  (e.g. extract to constant or extract to function) and user will be given
+  choice to select the one he/she likes.


I tend to just write "they" as a gender neutral term.

Yes. That sounds better.

w0rp · 2020-11-14T10:05:20Z

autoload/ale/completion.vim

@@ -617,6 +617,7 @@ function! ale#completion#ParseLSPCompletions(response) abort
        let l:user_data = {'_ale_completion_item': 1}

        if has_key(l:item, 'additionalTextEdits')
+        \ && l:item.additionalTextEdits isnot v:null


Suggested change

\ && l:item.additionalTextEdits isnot v:null

\&& l:item.additionalTextEdits isnot v:null

Preference is to not add a space.

w0rp · 2020-11-14T10:06:15Z

autoload/ale/codefix.vim

+    let l:end_column = min([l:end_column, len(getline(l:end_line))])
+
+    let l:Callback = function(
+    \ 's:OnReady', [l:line, l:column, l:end_line, l:end_column])


I tend to put the closing parenthesis on its own line.

w0rp · 2020-11-14T10:15:29Z

Cheers! 🍻

daliusd · 2020-11-14T11:50:06Z

Cheers! 🍻

* Added tsserver and LSP code action support. * tsserver refactors support added. * Handling special case when new text is added after new line symbol. * ale#code_action#ApplyChanges simplified. * Initial attempt on LSP Code Actions. * workspace/executeCommand added. * Some null checks added. * Add last column to LSP Code Action message. * Pass diagnostics to LSP code action. Previously ApplyChanges code was applied from top-to-bottom that required extra parameters to track progress and there was bug. I have changed code to bottom-to-top approach as that does not require those extra parameters and solved the bug. Tested with typescript-language-server and it is working.

* origin/master: (40 commits) fix: correct suggested filetype for yamlfix feat: add yamlfix fixer Use _config for LSP config options Add support for R languageserver (dense-analysis#3370) Fix 3103 - add shellcheck shell directive detection. (dense-analysis#3216) Added the Vundle command in installation instructions (dense-analysis#3400) Adds support for Tlint - A Tighten Opinionated PHP Linter (dense-analysis#3291) Add php phpcbf options (dense-analysis#3383) Use has('gui_running') instead of has('gui') Close dense-analysis#2727 - Add a hover-only setting for balloons Fix dense-analysis#3332 - Modify everything for rename/actions Add a missing blank line in documentation Add luafmt fixer (dense-analysis#3289) dense-analysis#3442 Fix code fix clangd issue Close dense-analysis#1466 - Add GVIM refactor menu support Look for node packages in .yarn/sdks as well Update documentation for code actions and rename cmp forwards, and reverse the code actions Support for LSP/tsserver Code Actions (dense-analysis#3437) Move the test for buffer-local variables ...

* origin/master: (164 commits) fix: correct suggested filetype for yamlfix feat: add yamlfix fixer Use _config for LSP config options Add support for R languageserver (dense-analysis#3370) Fix 3103 - add shellcheck shell directive detection. (dense-analysis#3216) Added the Vundle command in installation instructions (dense-analysis#3400) Adds support for Tlint - A Tighten Opinionated PHP Linter (dense-analysis#3291) Add php phpcbf options (dense-analysis#3383) Use has('gui_running') instead of has('gui') Close dense-analysis#2727 - Add a hover-only setting for balloons Fix dense-analysis#3332 - Modify everything for rename/actions Add a missing blank line in documentation Add luafmt fixer (dense-analysis#3289) dense-analysis#3442 Fix code fix clangd issue Close dense-analysis#1466 - Add GVIM refactor menu support Look for node packages in .yarn/sdks as well Update documentation for code actions and rename cmp forwards, and reverse the code actions Support for LSP/tsserver Code Actions (dense-analysis#3437) Move the test for buffer-local variables ...

* Added tsserver and LSP code action support. * tsserver refactors support added. * Handling special case when new text is added after new line symbol. * ale#code_action#ApplyChanges simplified. * Initial attempt on LSP Code Actions. * workspace/executeCommand added. * Some null checks added. * Add last column to LSP Code Action message. * Pass diagnostics to LSP code action. Previously ApplyChanges code was applied from top-to-bottom that required extra parameters to track progress and there was bug. I have changed code to bottom-to-top approach as that does not require those extra parameters and solved the bug. Tested with typescript-language-server and it is working.

* master: (35 commits) fix: correct suggested filetype for yamlfix feat: add yamlfix fixer Use _config for LSP config options Add support for R languageserver (dense-analysis#3370) Fix 3103 - add shellcheck shell directive detection. (dense-analysis#3216) Added the Vundle command in installation instructions (dense-analysis#3400) Adds support for Tlint - A Tighten Opinionated PHP Linter (dense-analysis#3291) Add php phpcbf options (dense-analysis#3383) Use has('gui_running') instead of has('gui') Close dense-analysis#2727 - Add a hover-only setting for balloons Fix dense-analysis#3332 - Modify everything for rename/actions Add a missing blank line in documentation Add luafmt fixer (dense-analysis#3289) dense-analysis#3442 Fix code fix clangd issue Close dense-analysis#1466 - Add GVIM refactor menu support Look for node packages in .yarn/sdks as well Update documentation for code actions and rename cmp forwards, and reverse the code actions Support for LSP/tsserver Code Actions (dense-analysis#3437) feat: add autoimport fixer ...

daliusd added 24 commits October 30, 2020 00:30

CodeFix implementation

0163a81

Relates issue #1466

Tests added. Minor changes.

278ccb9

ALECodeFix documented.

58ec8ae

Vint problem fix.

def3a2d

It seems this line must be added.

7002207

Use only errors with code.

5f5f577

There might be situations when the error is reported by multiple sources at the same location (e.g. eslint and tsserver). In that case first source might be missing `code`.

ALECodeFix renamed to ALECodeAction.

e7c14eb

This is done to accommodate the fact that in the future there will be more capabilities: refactorings from tsserver and LSP Code Actions.

tsserver refactors support added.

a762e32

Minor fix.

0abbe1b

Attempt to fix <range> problem in tests.

ff6abac

Call function instead of command.

bca2ec8

We will lose one testing layer but I think it is acceptable in this situation.

Handling special case when new text is added after new line symbol.

d40b4b9

It seems edits assumes that lines includes end-of-line symbol. Meanwhile Vim's readfile command omits new lines (\n) and carriage return (\r) symbols if there are any.

Text fixed.

747cea9

ale#code_action#ApplyChanges simplified.

5cfc644

Previously code was applied from top-to-bottom that required extra parameters to track progress and there was bug. I have changed code to bottom-to-top approach as that does not require those extra parameters and solved the bug.

Initial attempt on LSP Code Actions.

3dbac74

Minor fix.

2d74cde

workspace/executeCommand added.

e2839d2

Minor improvement.

8b6df35

Some null checks added.

86a34f9

E.g.: jedi-language-server returns null in some cases.

Add last column to LSP Code Action message.

ce2f468

Pass diagnostics to LSP code action.

0c7021c

Tested with typescript-language-server and it is working.

Couple new tests added.

d385920

Even more tests.

a258a51

Even more tests.

a626ca5

daliusd mentioned this pull request Nov 14, 2020

tsserver code actions implementation #3418

Closed

daliusd added 2 commits November 14, 2020 10:50

Tests fixed.

9faca44

One more test fixed.

8fe3cc7

w0rp approved these changes Nov 14, 2020

View reviewed changes

w0rp merged commit 01800a2 into dense-analysis:master Nov 14, 2020

daliusd deleted the codeactions branch November 14, 2020 11:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for LSP/tsserver Code Actions #3437

Support for LSP/tsserver Code Actions #3437

daliusd commented Nov 14, 2020

w0rp left a comment

w0rp Nov 14, 2020

daliusd Nov 14, 2020

w0rp Nov 14, 2020

w0rp Nov 14, 2020

daliusd Nov 14, 2020

w0rp Nov 14, 2020

w0rp Nov 14, 2020

w0rp commented Nov 14, 2020

daliusd commented Nov 14, 2020


		Code Actions support for `tsserver`.

		There are two different kind of actions supported for `tsserver`. If run in

	\ && l:item.additionalTextEdits isnot v:null
	\&& l:item.additionalTextEdits isnot v:null

Support for LSP/tsserver Code Actions #3437

Support for LSP/tsserver Code Actions #3437

Conversation

daliusd commented Nov 14, 2020

w0rp left a comment

Choose a reason for hiding this comment

w0rp Nov 14, 2020

Choose a reason for hiding this comment

daliusd Nov 14, 2020

Choose a reason for hiding this comment

w0rp Nov 14, 2020

Choose a reason for hiding this comment

w0rp Nov 14, 2020

Choose a reason for hiding this comment

daliusd Nov 14, 2020

Choose a reason for hiding this comment

w0rp Nov 14, 2020

Choose a reason for hiding this comment

w0rp Nov 14, 2020

Choose a reason for hiding this comment

w0rp commented Nov 14, 2020

daliusd commented Nov 14, 2020