Fix 3103 - add shellcheck shell directive detection. #3216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Searches for shellcheck shell directive to detect dialects for scripts that do not have shebang.
|
This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See |
codemedic
previously approved these changes
Sep 23, 2020
In a situation where the filetype can be wrong (example: something.sh which is written in bash dialect) and has no hash-bang (since it is meant to be sourced) then the override specified within the script will be ignored. It probably is the most right thing to do if the script author has added a specific directive; it should trump everything else.
…ive-detection-change-order Change order of detection of shellcheck dialect
|
This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See |
w0rp
approved these changes
Nov 21, 2020
|
Cheers! 🍻 |
ivorpeles
pushed a commit
to ivorpeles/ale
that referenced
this pull request
Nov 22, 2020
…3216) * Fix 3103 - add shellcheck shell directive detection. Searches for shellcheck shell directive to detect dialects for scripts that do not have shebang. * Change order of detection of shellcheck dialect In a situation where the filetype can be wrong (example: something.sh which is written in bash dialect) and has no hash-bang (since it is meant to be sourced) then the override specified within the script will be ignored. It probably is the most right thing to do if the script author has added a specific directive; it should trump everything else. Co-authored-by: Horacio Sanson <horacio@allm.inc> Co-authored-by: Dino Korah <dino.korah@redmatter.com>
benknoble
added a commit
to benknoble/ale
that referenced
this pull request
Nov 30, 2020
* origin/master: (40 commits) fix: correct suggested filetype for yamlfix feat: add yamlfix fixer Use _config for LSP config options Add support for R languageserver (dense-analysis#3370) Fix 3103 - add shellcheck shell directive detection. (dense-analysis#3216) Added the Vundle command in installation instructions (dense-analysis#3400) Adds support for Tlint - A Tighten Opinionated PHP Linter (dense-analysis#3291) Add php phpcbf options (dense-analysis#3383) Use has('gui_running') instead of has('gui') Close dense-analysis#2727 - Add a hover-only setting for balloons Fix dense-analysis#3332 - Modify everything for rename/actions Add a missing blank line in documentation Add luafmt fixer (dense-analysis#3289) dense-analysis#3442 Fix code fix clangd issue Close dense-analysis#1466 - Add GVIM refactor menu support Look for node packages in .yarn/sdks as well Update documentation for code actions and rename cmp forwards, and reverse the code actions Support for LSP/tsserver Code Actions (dense-analysis#3437) Move the test for buffer-local variables ...
jsit
added a commit
to jsit/ale
that referenced
this pull request
Dec 26, 2020
* origin/master: (164 commits) fix: correct suggested filetype for yamlfix feat: add yamlfix fixer Use _config for LSP config options Add support for R languageserver (dense-analysis#3370) Fix 3103 - add shellcheck shell directive detection. (dense-analysis#3216) Added the Vundle command in installation instructions (dense-analysis#3400) Adds support for Tlint - A Tighten Opinionated PHP Linter (dense-analysis#3291) Add php phpcbf options (dense-analysis#3383) Use has('gui_running') instead of has('gui') Close dense-analysis#2727 - Add a hover-only setting for balloons Fix dense-analysis#3332 - Modify everything for rename/actions Add a missing blank line in documentation Add luafmt fixer (dense-analysis#3289) dense-analysis#3442 Fix code fix clangd issue Close dense-analysis#1466 - Add GVIM refactor menu support Look for node packages in .yarn/sdks as well Update documentation for code actions and rename cmp forwards, and reverse the code actions Support for LSP/tsserver Code Actions (dense-analysis#3437) Move the test for buffer-local variables ...
motato1
pushed a commit
to motato1/ale
that referenced
this pull request
Jan 11, 2021
…3216) * Fix 3103 - add shellcheck shell directive detection. Searches for shellcheck shell directive to detect dialects for scripts that do not have shebang. * Change order of detection of shellcheck dialect In a situation where the filetype can be wrong (example: something.sh which is written in bash dialect) and has no hash-bang (since it is meant to be sourced) then the override specified within the script will be ignored. It probably is the most right thing to do if the script author has added a specific directive; it should trump everything else. Co-authored-by: Horacio Sanson <horacio@allm.inc> Co-authored-by: Dino Korah <dino.korah@redmatter.com>
jsit
added a commit
to jsit/ale
that referenced
this pull request
Apr 19, 2021
* master: (35 commits) fix: correct suggested filetype for yamlfix feat: add yamlfix fixer Use _config for LSP config options Add support for R languageserver (dense-analysis#3370) Fix 3103 - add shellcheck shell directive detection. (dense-analysis#3216) Added the Vundle command in installation instructions (dense-analysis#3400) Adds support for Tlint - A Tighten Opinionated PHP Linter (dense-analysis#3291) Add php phpcbf options (dense-analysis#3383) Use has('gui_running') instead of has('gui') Close dense-analysis#2727 - Add a hover-only setting for balloons Fix dense-analysis#3332 - Modify everything for rename/actions Add a missing blank line in documentation Add luafmt fixer (dense-analysis#3289) dense-analysis#3442 Fix code fix clangd issue Close dense-analysis#1466 - Add GVIM refactor menu support Look for node packages in .yarn/sdks as well Update documentation for code actions and rename cmp forwards, and reverse the code actions Support for LSP/tsserver Code Actions (dense-analysis#3437) feat: add autoimport fixer ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Searches for shellcheck shell directive to detect dialects for scripts
that do not have shebang.
Closes #3103