Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a setting for only using balloons for LSP/tsserver hovering #2727

Closed
w0rp opened this issue Aug 23, 2019 · 1 comment
Closed

Implement a setting for only using balloons for LSP/tsserver hovering #2727

w0rp opened this issue Aug 23, 2019 · 1 comment
Assignees
Labels
enhancement LSP Any issue relating to LSP or tsserver

Comments

@w0rp
Copy link
Member

w0rp commented Aug 23, 2019

The balloonexpr function ALE offers has the dual purpose of showing diagnostic messages, which long predate the existence of Language Server Protocol, and also for showing information about the symbol at the cursor via tsserver and LSP servers. I want to add a setting to make mouse hovering only show the "hover" information for symbols, and never the errors. This should be a simple change to make, by supporting a string for g:ale_set_balloons for this mode. See #2697 for a related change that would make sense to implement at the same time.

I had considered having a setting for reversing the priority of message for a while, but the asynchronous nature of how hovering works with the client-server communication would make the user experience less than good. Therefore, I'm content to just add a setting for turning the balloon diagnostics off.

@w0rp w0rp added enhancement LSP Any issue relating to LSP or tsserver labels Aug 23, 2019
@w0rp w0rp self-assigned this Jan 23, 2020
@w0rp w0rp closed this as completed in a139599 Nov 21, 2020
@w0rp
Copy link
Member Author

w0rp commented Nov 21, 2020

You can now do something like this to use balloons only for hover information.

let g:ale_set_balloons = has('gui_running') ? 'hover' : 0

benknoble added a commit to benknoble/ale that referenced this issue Nov 30, 2020
* origin/master: (40 commits)
  fix: correct suggested filetype for yamlfix
  feat: add yamlfix fixer
  Use _config for LSP config options
  Add support for R languageserver (dense-analysis#3370)
  Fix 3103 - add shellcheck shell directive detection. (dense-analysis#3216)
  Added the Vundle command in installation instructions (dense-analysis#3400)
  Adds support for Tlint - A Tighten Opinionated PHP Linter (dense-analysis#3291)
  Add php phpcbf options (dense-analysis#3383)
  Use has('gui_running') instead of has('gui')
  Close dense-analysis#2727 - Add a hover-only setting for balloons
  Fix dense-analysis#3332 - Modify everything for rename/actions
  Add a missing blank line in documentation
  Add luafmt fixer (dense-analysis#3289)
  dense-analysis#3442 Fix code fix clangd issue
  Close dense-analysis#1466 - Add GVIM refactor menu support
  Look for node packages in .yarn/sdks as well
  Update documentation for code actions and rename
  cmp forwards, and reverse the code actions
  Support for LSP/tsserver Code Actions (dense-analysis#3437)
  Move the test for buffer-local variables
  ...
jsit added a commit to jsit/ale that referenced this issue Dec 26, 2020
* origin/master: (164 commits)
  fix: correct suggested filetype for yamlfix
  feat: add yamlfix fixer
  Use _config for LSP config options
  Add support for R languageserver (dense-analysis#3370)
  Fix 3103 - add shellcheck shell directive detection. (dense-analysis#3216)
  Added the Vundle command in installation instructions (dense-analysis#3400)
  Adds support for Tlint - A Tighten Opinionated PHP Linter (dense-analysis#3291)
  Add php phpcbf options (dense-analysis#3383)
  Use has('gui_running') instead of has('gui')
  Close dense-analysis#2727 - Add a hover-only setting for balloons
  Fix dense-analysis#3332 - Modify everything for rename/actions
  Add a missing blank line in documentation
  Add luafmt fixer (dense-analysis#3289)
  dense-analysis#3442 Fix code fix clangd issue
  Close dense-analysis#1466 - Add GVIM refactor menu support
  Look for node packages in .yarn/sdks as well
  Update documentation for code actions and rename
  cmp forwards, and reverse the code actions
  Support for LSP/tsserver Code Actions (dense-analysis#3437)
  Move the test for buffer-local variables
  ...
jsit added a commit to jsit/ale that referenced this issue Apr 19, 2021
* master: (35 commits)
  fix: correct suggested filetype for yamlfix
  feat: add yamlfix fixer
  Use _config for LSP config options
  Add support for R languageserver (dense-analysis#3370)
  Fix 3103 - add shellcheck shell directive detection. (dense-analysis#3216)
  Added the Vundle command in installation instructions (dense-analysis#3400)
  Adds support for Tlint - A Tighten Opinionated PHP Linter (dense-analysis#3291)
  Add php phpcbf options (dense-analysis#3383)
  Use has('gui_running') instead of has('gui')
  Close dense-analysis#2727 - Add a hover-only setting for balloons
  Fix dense-analysis#3332 - Modify everything for rename/actions
  Add a missing blank line in documentation
  Add luafmt fixer (dense-analysis#3289)
  dense-analysis#3442 Fix code fix clangd issue
  Close dense-analysis#1466 - Add GVIM refactor menu support
  Look for node packages in .yarn/sdks as well
  Update documentation for code actions and rename
  cmp forwards, and reverse the code actions
  Support for LSP/tsserver Code Actions (dense-analysis#3437)
  feat: add autoimport fixer
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement LSP Any issue relating to LSP or tsserver
Projects
None yet
Development

No branches or pull requests

1 participant