Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

686 | Refactor code away from Central Mail #92235

Open
5 tasks
steele-lm opened this issue Sep 5, 2024 · 0 comments
Open
5 tasks

686 | Refactor code away from Central Mail #92235

steele-lm opened this issue Sep 5, 2024 · 0 comments
Assignees
@mreed101
Labels
backend dependents-benefits engineering Engineering topics logging
Milestone
ND/D ZSF | Stage ...

Comments

@steele-lm
Copy link
Contributor

steele-lm commented Sep 5, 2024 •
edited by sanjabaj2
Loading

Issue Description

Any use of CentralMail namespaces within the 686 submission workflow needs to be refactored, ie. CentralMailSubmissionSerializer and CentralMail::DatestampPdf, etc.

Tasks

  • refactor submission code to remove "CentralMail" references, reuse other existing class if possible

Acceptance Criteria

  • no use of CentralMail classes within the submission workflow
  • new code is 100% covered by unit tests
  • new code is 100% documented - yardoc syntax
  • All relevant monitors updated to point to new code
@steele-lm steele-lm added backend VRE-CH31 Veteran Readiness and Employment (CH31) non-disability-benefits labels Sep 5, 2024
@steele-lm steele-lm changed the title Copy of VRE | Refactor code away from Central Mail 686 | Refactor code away from Central Mail Sep 5, 2024
@steele-lm steele-lm added dependents-benefits logging and removed VRE-CH31 Veteran Readiness and Employment (CH31) non-disability-benefits labels Sep 5, 2024
@steele-lm steele-lm assigned steele-lm and evansmith and unassigned steele-lm Sep 5, 2024
@steele-lm steele-lm added the engineering Engineering topics label Oct 3, 2024
@mreed101 mreed101 self-assigned this Nov 6, 2024
@mreed101 mreed101 mentioned this issue Nov 12, 2024
Closed
9 tasks
@mreed101 mreed101 mentioned this issue Nov 25, 2024
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mreed101 mreed101

Labels
backend dependents-benefits engineering Engineering topics logging
Projects
None yet
Milestone
ND/D ZSF | Stage 2 (Confirmation Page...
Development

No branches or pull requests
3 participants
@evansmith @mreed101 @steele-lm