namepace update from CentralMail to BenefitsIntake #19595

mreed101 · 2024-11-25T13:36:14Z

CentralMail namespaces within the 686 submission workflow have been updated to BenefitsIntake.

Summary

This work is behind a feature toggle (flipper): NO
CentralMail for for 686 has been renamed to BenefitsIntake to clear up confusion as we use lighthouse for handling submissions
BenefitsIntake is more consistent and allows us to change service later on without the need to rename services or modules again
VA Benefits and Claims
(If introducing a flipper, what is the success criteria being targeted?)

Related issue(s)

686 | Refactor code away from Central Mail va.gov-team#92235

Testing done

New code is covered by unit tests
The apps behavior does not change
Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
This is not a new feature

Screenshots

Note: Optional

What areas of the site does it impact?

Impacts are possible to form 686c submissions

Acceptance criteria

I fixed|updated|added unit tests and integration tests for each feature (if applicable).
No error nor warning in the console.
Events are being sent to the appropriate logging solution
Documentation has been updated (link to documentation)
No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
Feature/bug has a monitor built into Datadog (if applicable)
If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
I added a screenshot of the developed feature

Requested Feedback

We should throughly test the 686c workflow to ensure that all forms are being submitted properly and that logging is still accurate.

github-actions · 2024-11-25T13:36:57Z

	1 Error
🚫	This PR changes `559` LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, those exceeding `500` will not be reviewed, nor will they be allowed to merge. Please break this PR up into smaller ones. If you have reason to believe that this PR should be granted an exception, please see the Submitting pull requests for approval - FAQ. File Summary Files .github/CODEOWNERS (+2/-2) app/controllers/claims_base_controller.rb (+1/-1) app/serializers/{central_mail_submission_serializer.rb => benefits_intake_submission_serializer.rb} (+1/-1) app/services/bgs/dependent_service.rb (+5/-3) app/sidekiq/bgs/submit_form674_job.rb (+14/-5) app/sidekiq/bgs/submit_form686c_job.rb (+5/-3) app/sidekiq/central_mail/submit_central_form686c_job.rb (+0/-228) app/sidekiq/lighthouse/benefits_intake/delete_old_claims.rb (+18/-0) app/sidekiq/lighthouse/benefits_intake/submit_central_form686c_job.rb (+233/-0) app/sidekiq/lighthouse/income_and_assets_intake_job.rb (+2/-2) lib/dependents/monitor.rb (+2/-1) spec/lib/dependents/monitor_spec.rb (+4/-2) spec/serializers/{central_mail_submission_serializer_spec.rb => benefits_intake_submission_serializer_spec.rb} (+1/-1) spec/sidekiq/{central_mail => lighthouse/benefits_intake}/submit_central_form686c_job_spec.rb (+13/-9) Note: We exclude files matching the following when considering PR size: `.csv, .json, .tsv, .txt, .md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, .bru, *.pdf` Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

mreed101 · 2024-11-25T17:32:55Z

1 Error
🚫 This PR changes 531 LoC (not counting whitespace/newlines).
In order to ensure each PR receives the proper attention it deserves, those exceeding 500 will not be reviewed, nor will they be allowed to merge. Please break this PR up into smaller ones.

If you have reason to believe that this PR should be granted an exception, please see the Submitting pull requests for approval - FAQ.

File Summary
Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

A file was deleted from a previous folder and moved to a different one. The file in question was already over LoC which is leading to this error.

evansmith

@mreed101 can you go through app/services/bgs/dependent_service.rb, app/sidekiq/bgs/submit_form674_job.rb, and app/sidekiq/bgs/submit_form686c_job.rb to clear out the references to CentralMail::SubmitCentralForm686cJob

Also there are a few logs that link to datadog dashboards that reference CentralMail::SubmitCentralForm686cJob. Should those messages and dashboards be updated?

mreed101 · 2024-11-25T18:49:16Z

@mreed101 can you go through app/services/bgs/dependent_service.rb, app/sidekiq/bgs/submit_form674_job.rb, and app/sidekiq/bgs/submit_form686c_job.rb to clear out the references to CentralMail::SubmitCentralForm686cJob

Also there are a few logs that link to datadog dashboards that reference CentralMail::SubmitCentralForm686cJob. Should those messages and dashboards be updated?

Modified in the latest commit.

evansmith

LGTM, thanks for adding those changes!

ericboehs · 2024-12-12T16:43:08Z

spec/lib/dependents/monitor_spec.rb

@@ -66,7 +66,7 @@
    it 'logs sidekiq job exhaustion with failure avoided' do
      msg = { 'args' => [claim.id, encrypted_vet_info, encrypted_user], error_message: 'Error!' }

-      log = "Failed all retries on CentralMail::SubmitCentralForm686cJob, last error: #{msg['error_message']}"
+      log = "Failed all retries on Lighthouse::BenefitsIntake::SubmitCentralForm686cJob, last error: #{msg['error_message']}" # rubocop:disable Layout/LineLength


Could you expand these please?

Suggested change

log = "Failed all retries on Lighthouse::BenefitsIntake::SubmitCentralForm686cJob, last error: #{msg['error_message']}" # rubocop:disable Layout/LineLength

log = 'Failed all retries on Lighthouse::BenefitsIntake::SubmitCentralForm686cJob, ' \

"last error: #{msg['error_message']}"

This was modified @ericboehs, please take another look if you get a chance.

ericboehs · 2024-12-13T17:14:28Z

lib/dependents/monitor.rb

@@ -38,7 +38,7 @@ def track_submission_exhaustion(msg, email = nil)

      StatsD.increment("#{SUBMISSION_STATS_KEY}.exhausted")
      Rails.logger.error(
-        "Failed all retries on CentralMail::SubmitCentralForm686cJob, last error: #{msg['error_message']}"
+        "Failed all retries on Lighthouse::BenefitsIntake::SubmitCentralForm686cJob, last error: #{msg['error_message']}" # rubocop:disable Layout/LineLength


Here's another line that could be split up to avoid skirting the rubocop check

This has been resolved in my latest push @ericboehs

* namepace update from CentralMail to BenefitsIntake * updated remaining CentralMail items * fixed linting * removes rubocop disable from monitor spec * removed rubocop disable

namepace update from CentralMail to BenefitsIntake

53a3697

github-actions bot added the test-passing label Nov 25, 2024

evansmith requested changes Nov 25, 2024

View reviewed changes

updated remaining CentralMail items

085faa2

github-actions bot removed the test-passing label Nov 25, 2024

github-actions bot added the test-passing label Nov 25, 2024

evansmith previously approved these changes Nov 25, 2024

View reviewed changes

mreed101 marked this pull request as ready for review November 25, 2024 19:25

mreed101 requested review from a team as code owners November 25, 2024 19:25

github-actions bot added require-backend-approval and removed require-backend-approval labels Nov 25, 2024

va-vfs-bot temporarily deployed to vabc/jr/rename-central-mail-686/main/main November 25, 2024 20:42 Inactive

rjohnson2011 previously approved these changes Nov 26, 2024

View reviewed changes

github-actions bot removed the test-passing label Dec 4, 2024

va-vfs-bot temporarily deployed to vabc/jr/rename-central-mail-686/main/main December 4, 2024 18:33 Inactive

merged master

0d19e42

mreed101 dismissed rjohnson2011’s stale review via 0d19e42 December 11, 2024 19:08

github-actions bot added the lint-failure label Dec 11, 2024

va-vfs-bot temporarily deployed to vabc/jr/rename-central-mail-686/main/main December 11, 2024 19:17 Inactive

github-actions bot added test-passing and removed test-failure labels Dec 11, 2024

fixed linting

e8e7035

github-actions bot removed the lint-failure label Dec 12, 2024

va-vfs-bot temporarily deployed to vabc/jr/rename-central-mail-686/main/main December 12, 2024 16:39 Inactive

ericboehs reviewed Dec 12, 2024

View reviewed changes

removes rubocop disable from monitor spec

5d66625

github-actions bot added test-failure and removed test-passing labels Dec 12, 2024

va-vfs-bot temporarily deployed to vabc/jr/rename-central-mail-686/main/main December 12, 2024 18:44 Inactive

ericboehs reviewed Dec 13, 2024

View reviewed changes

removed rubocop disable

3dcebb4

va-vfs-bot temporarily deployed to vabc/jr/rename-central-mail-686/main/main December 16, 2024 17:20 Inactive

github-actions bot added test-passing and removed test-failure labels Dec 16, 2024

ericboehs approved these changes Dec 16, 2024

View reviewed changes

Merge branch 'master' into vabc/jr/rename-central-mail-686

c2b58b0

va-vfs-bot temporarily deployed to vabc/jr/rename-central-mail-686/main/main December 16, 2024 18:54 Inactive

platform-support-slack-integration bot mentioned this pull request Dec 27, 2024

Hello, I need backend approval on https://github.com/departm... department-of-veterans-affairs/va.gov-team#99695

Closed

ryan-mcneil approved these changes Dec 27, 2024

View reviewed changes

ryan-mcneil merged commit 055dac4 into master Dec 27, 2024
20 of 21 checks passed

ryan-mcneil deleted the vabc/jr/rename-central-mail-686 branch December 27, 2024 17:11

wayne-weibel mentioned this pull request Jan 6, 2025

Burial | Fix BenefitIntake::Metadata namespace issue department-of-veterans-affairs/va.gov-team#100034

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

namepace update from CentralMail to BenefitsIntake #19595

namepace update from CentralMail to BenefitsIntake #19595

mreed101 commented Nov 25, 2024

github-actions bot commented Nov 25, 2024 •

edited

Loading

Files

mreed101 commented Nov 25, 2024

evansmith left a comment

mreed101 commented Nov 25, 2024

evansmith left a comment

ericboehs Dec 12, 2024

mreed101 Dec 12, 2024

ericboehs Dec 13, 2024

mreed101 Dec 16, 2024

	log = "Failed all retries on Lighthouse::BenefitsIntake::SubmitCentralForm686cJob, last error: #{msg['error_message']}" # rubocop:disable Layout/LineLength
	log = 'Failed all retries on Lighthouse::BenefitsIntake::SubmitCentralForm686cJob, ' \
	"last error: #{msg['error_message']}"

namepace update from CentralMail to BenefitsIntake #19595

namepace update from CentralMail to BenefitsIntake #19595

Conversation

mreed101 commented Nov 25, 2024

Summary

Related issue(s)

Testing done

Screenshots

What areas of the site does it impact?

Acceptance criteria

Requested Feedback

github-actions bot commented Nov 25, 2024 • edited Loading

Files

mreed101 commented Nov 25, 2024

evansmith left a comment

Choose a reason for hiding this comment

mreed101 commented Nov 25, 2024

evansmith left a comment

Choose a reason for hiding this comment

ericboehs Dec 12, 2024

Choose a reason for hiding this comment

mreed101 Dec 12, 2024

Choose a reason for hiding this comment

ericboehs Dec 13, 2024

Choose a reason for hiding this comment

mreed101 Dec 16, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 25, 2024 •

edited

Loading