Feature - call VRO contention classification service for some 526-ez claims #12638
Conversation
…s-affairs/vets-api into feature-27-call-cc
keep contention classification disabled for most tests fix client_spec, delete outdated test cases Update VRO client to be RRD-agnostic Fix VRO client test Clean up submit_form526_all_claim_spec
lukey-luke
changed the title
Generated by 🚫 Danger |
| end | ||
|
|
||
| def update_form_with_classification(_classification_code) | ||
| # TODO: update form[FORM_526] to include the classification code |
There was a problem hiding this comment.
Is the intention of this to (eventually) just overwrite with the correct classification code?
Is it also the intention to overwrite what would come back from the "model"? I would think there could be issues with that if so, but, just checking.
| diagnosticCode: @diagnostic_code, | ||
| claimSubmissionId: @claim_submission_id | ||
| diagnosticCode: diagnostic_code, | ||
| claimSubmissionId: claim_submission_id | ||
| } | ||
|
|
||
| perform(:post, Settings.virtual_regional_office.health_assessment_path, params.to_json.to_s, headers_hash) |
There was a problem hiding this comment.
params.to_json.to_s 🤔
I know you didnt change this but this could just be params.to_json, it should always return a string (or an error)
Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.
Summary
Related issue(s)
Testing done
bundle exec rspec vets-api/spec/jobs/evss/disability_compensation_form/submit_form526_all_claim_spec.rbScreenshots
Note: Optional
What areas of the site does it impact?
(Describe what parts of the site are impacted andifcode touched other areas)
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?