update Form526Submission.form w/ classificationCode before submitting to eVSS #12905

lukey-luke · 2023-06-06T14:47:43Z

Summary

vets-api talks to VRO contention classification service for a subset of 526-ez claims
for claims that are classified by VRO, the response includes a classification code which needs to be input into eVSS's submit_form526 endpoint
this code is a follow-up from Feature - call VRO contention classification service for some 526-ez claims #12638 to actually make use of the data

Related issue(s)

original discussion from: https://github.com/department-of-veterans-affairs/vagov-claim-classification/issues/16
this work is captured in: https://github.com/department-of-veterans-affairs/vagov-claim-classification/issues/170

Testing done

this is covered in bundle exec rspec /Users/verdanceluke/kyle_example/vets-api/spec/jobs/evss/disability_compensation_form/submit_form526_all_claim_spec.rb:84

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

sidekiq job on the backend
this job is kicked off after veteran clicks submit on 526-ez form

Acceptance criteria

I fixed|updated|added unit tests and integration tests for each feature (if applicable).
No error nor warning in the console.
Events are being sent to the appropriate logging solution
- Rails.logger added here in order to improve monitoring in datadog for this
Documentation has been updated (link to documentation)
- n/a, eVSS has been notified and will make the api change available in staging later this week
No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
Feature/bug has a monitor built into Datadog or Grafana (if applicable)
- added logging, which I believe should be searchable in Datadog
If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
- n/a tested via rspec
I added a screenshot of the developed feature

Misc

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

mchae-nava

Have some outcomes from the LH thread, but in the meantime, some considerations

app/models/concerns/form526_rapid_ready_for_decision_concern.rb

spec/jobs/evss/disability_compensation_form/submit_form526_all_claim_spec.rb

app/models/concerns/form526_rapid_ready_for_decision_concern.rb

kylesoskin

Do you want the contention code given to be overwritten with nil if the service returns nil? (what it looks like it is currently doing) or is it supposed to keep the code it had if the service does not return a code?

jeremy6d

This was a good PR! Just one little comment but definitely not a blocker. Appreciate the writeup -- always nice for us on support to kind of have more info on what the work's purpose is and where it touches.

jeremy6d · 2023-06-09T15:28:45Z

config/settings.yml

  api_key: 9d3868d1-ec15-4889-8002-2bff1b50ba62
  health_assessment_path: health-data-assessment
  evidence_pdf_path: evidence-pdf
-  ctn_classification_path: contention-classification/classifier
+  # ctn_classification_path: contention-classification/classifier


do we still need this comment in here?

… to eVSS (#12905) * fix missing request param * log submission id before classification * write update_form_classification() to actually update the form for eVSS * WIP - troubleshooting method not getting called * wip endponit * still WIP testing form update functionality * fix logic for updating form, test against changed outputs * remove comment * fix rubocop issues * remove safeguards for handling legacy vro code * simplify form update function * update spec mock request to resemble current api response * address rubocop * change logging statement to work better w/ datadog * switch to form.to_json * move nil check up * update settings for local vro testing * add additional test case for handling null response * address rubocop issues * address rubocop issue * update spec to reflect latest vro api response --------- Co-authored-by: verdanceluke <luke@verdance.co>

github-actions bot added the console-services-review label Jun 6, 2023

va-vfs-bot temporarily deployed to bugfix-cc-endpoint/main/main June 6, 2023 14:48 Inactive

va-vsp-bot requested a deployment to bugfix-cc-endpoint/main/main June 6, 2023 14:56 In progress

va-vsp-bot requested a deployment to bugfix-cc-endpoint/main/main June 6, 2023 14:57 In progress

va-vfs-bot temporarily deployed to bugfix-cc-endpoint/main/main June 6, 2023 14:58 Inactive

lukey-luke requested a review from mchae-nava June 6, 2023 15:01

lukey-luke marked this pull request as ready for review June 6, 2023 15:01

lukey-luke requested review from a team as code owners June 6, 2023 15:01

va-vfs-bot temporarily deployed to bugfix-cc-endpoint/main/main June 6, 2023 15:03 Inactive

mchae-nava reviewed Jun 6, 2023

View reviewed changes

va-vsp-bot requested a deployment to bugfix-cc-endpoint/main/main June 7, 2023 21:19 In progress

va-vfs-bot temporarily deployed to bugfix-cc-endpoint/main/main June 7, 2023 21:26 Inactive

va-vsp-bot requested a deployment to bugfix-cc-endpoint/main/main June 7, 2023 21:28 In progress

platform-support-slack-integration bot mentioned this pull request Jun 7, 2023

Please review https://github.com/department-of-veterans-affa... department-of-veterans-affairs/va.gov-team#59931

Closed

va-vfs-bot temporarily deployed to bugfix-cc-endpoint/main/main June 7, 2023 21:31 Inactive

va-vsp-bot requested a deployment to bugfix-cc-endpoint/main/main June 7, 2023 22:11 In progress

va-vfs-bot temporarily deployed to bugfix-cc-endpoint/main/main June 7, 2023 22:11 Inactive

kylesoskin reviewed Jun 8, 2023

View reviewed changes

app/models/concerns/form526_rapid_ready_for_decision_concern.rb Outdated Show resolved Hide resolved

kylesoskin reviewed Jun 8, 2023

View reviewed changes

app/models/concerns/form526_rapid_ready_for_decision_concern.rb Outdated Show resolved Hide resolved

app/models/concerns/form526_rapid_ready_for_decision_concern.rb Show resolved Hide resolved

kylesoskin reviewed Jun 8, 2023

View reviewed changes

app/models/concerns/form526_rapid_ready_for_decision_concern.rb Outdated Show resolved Hide resolved

kylesoskin reviewed Jun 8, 2023

View reviewed changes

va-vfs-bot temporarily deployed to bugfix-cc-endpoint/main/main June 8, 2023 16:07 Inactive

va-vsp-bot requested a deployment to bugfix-cc-endpoint/main/main June 8, 2023 16:10 In progress

va-vsp-bot requested a deployment to bugfix-cc-endpoint/main/main June 8, 2023 16:21 In progress

va-vfs-bot temporarily deployed to bugfix-cc-endpoint/main/main June 8, 2023 16:22 Inactive

va-vsp-bot requested a deployment to bugfix-cc-endpoint/main/main June 8, 2023 16:28 In progress

va-vfs-bot temporarily deployed to bugfix-cc-endpoint/main/main June 8, 2023 16:28 Inactive

va-vsp-bot requested a deployment to bugfix-cc-endpoint/main/main June 8, 2023 19:46 In progress

va-vsp-bot requested a deployment to bugfix-cc-endpoint/main/main June 8, 2023 19:52 In progress

va-vfs-bot temporarily deployed to bugfix-cc-endpoint/main/main June 8, 2023 19:55 Inactive

va-vsp-bot requested a deployment to bugfix-cc-endpoint/main/main June 8, 2023 22:48 In progress

va-vfs-bot temporarily deployed to bugfix-cc-endpoint/main/main June 8, 2023 22:49 Inactive

va-vsp-bot requested a deployment to bugfix-cc-endpoint/main/main June 8, 2023 23:19 In progress

va-vfs-bot temporarily deployed to bugfix-cc-endpoint/main/main June 8, 2023 23:19 Inactive

jeremy6d approved these changes Jun 9, 2023

View reviewed changes

lukey-luke merged commit a52cbef into master Jun 9, 2023

lukey-luke deleted the bugfix-cc-endpoint branch June 9, 2023 15:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update Form526Submission.form w/ classificationCode before submitting to eVSS #12905

update Form526Submission.form w/ classificationCode before submitting to eVSS #12905

lukey-luke commented Jun 6, 2023 •

edited

Loading

mchae-nava left a comment

kylesoskin left a comment

jeremy6d left a comment

jeremy6d Jun 9, 2023

update Form526Submission.form w/ classificationCode before submitting to eVSS #12905

update Form526Submission.form w/ classificationCode before submitting to eVSS #12905

Conversation

lukey-luke commented Jun 6, 2023 • edited Loading

Summary

Related issue(s)

Testing done

Screenshots

What areas of the site does it impact?

Acceptance criteria

Misc

Requested Feedback

mchae-nava left a comment

Choose a reason for hiding this comment

kylesoskin left a comment

Choose a reason for hiding this comment

jeremy6d left a comment

Choose a reason for hiding this comment

jeremy6d Jun 9, 2023

Choose a reason for hiding this comment

lukey-luke commented Jun 6, 2023 •

edited

Loading